From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Severe regressions in context of keyboard macros Date: Fri, 20 Sep 2019 10:23:58 +0300 Message-ID: <83a7aztoq9.fsf@gnu.org> References: Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="207758"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Christoph Arenz Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Sep 20 09:24:37 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iBDHL-000roJ-Hg for ged-emacs-devel@m.gmane.org; Fri, 20 Sep 2019 09:24:31 +0200 Original-Received: from localhost ([::1]:53024 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iBDHJ-0006RM-Ra for ged-emacs-devel@m.gmane.org; Fri, 20 Sep 2019 03:24:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56091) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iBDGl-0006Oo-NU for emacs-devel@gnu.org; Fri, 20 Sep 2019 03:23:56 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34355) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iBDGl-0000dJ-GK; Fri, 20 Sep 2019 03:23:55 -0400 Original-Received: from [176.228.60.248] (port=4104 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iBDGk-0006p2-SC; Fri, 20 Sep 2019 03:23:55 -0400 In-reply-to: (message from Christoph Arenz on Thu, 19 Sep 2019 10:17:17 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240176 Archived-At: > From: Christoph Arenz > Date: Thu, 19 Sep 2019 10:17:17 +0200 > > Calc: > I stumbled across the following bug using calc -- see also > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=37057: > 90 S I S > This calculates the sine and inverse sine of 90 -- with a result of 90. > It also records "IS" as a keyboard macro. > Now, let's use the macro to complete the same calculation: > 90 S > This worked until emacs-24.5 but is broken since emacs-25.1 where "ISS" is recorded as a keyboard macro > -- now leading to a result of 1. Calc seems to have various tricks related to keyboard macros (e.g., search for "kbd-macro"), so someone who knows Calc should go over that and adapt what Calc does there to the new method of recording and replaying keyboard macros. I expect the fix to be simple. > Dribble: > According to the documentation in open-dribble-file, this starts 'writing all keyboard characters to a dribble > file'. > However, the keys being recorded changed with commit 30a6b1f81412044a when a keyboard macro is > involved. > > Prior, the key "" was recorded when a macro was replayed. With the patch, the recording contains "" > and additionally all characters that were replayed by the macro. This gets ugly quickly, e.g. when was > used in the macro to insert a counter. Why is that a problem? I think the current dribble is more accurate, as it shows what was injected into the Emacs keyboard event queue. Thanks.