From: Eli Zaretskii <eliz@gnu.org>
To: Carlos Pita <carlosjosepita@gmail.com>
Cc: 37755@debbugs.gnu.org
Subject: bug#37755: Logic in init_fringe_bitmap should be moved to backends (maybe rif->define_fringe_bitmap)
Date: Tue, 15 Oct 2019 12:33:31 +0300 [thread overview]
Message-ID: <83a7a2gxp0.fsf@gnu.org> (raw)
In-Reply-To: <CAELgYhfpY38weDFd2yxy00Qnn1i41FNfX_1XVWru6Zmy-DKgUg@mail.gmail.com> (message from Carlos Pita on Mon, 14 Oct 2019 23:30:08 -0300)
> From: Carlos Pita <carlosjosepita@gmail.com>
> Date: Mon, 14 Oct 2019 23:30:08 -0300
>
> In fringe.c you have init_fringe_bitmap with this structure:
>
> ```
> #if defined (HAVE_X_WINDOWS)
> ...
> #ifdef USE_CAIRO
> ...
> #endif
> ...
> #endif
> #ifdef HAVE_NTGUI
> ...
> #endif
> if (!once_p)
> {
> ....
> rif->define_fringe_bitmap (...)
> ....
> }
> ```
>
> Now, this is backend specific code that should be moved behind the
> redisplay_interface.
Yes, it should.
> It seems to me that the obvious candidate to host that code is
> define_fringe_bitmap.
No, I think we need another interface, as define_fringe_bitmap is used
directly from other places.
next prev parent reply other threads:[~2019-10-15 9:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 2:30 bug#37755: Logic in init_fringe_bitmap should be moved to backends (maybe rif->define_fringe_bitmap) Carlos Pita
2019-10-15 9:33 ` Eli Zaretskii [this message]
2019-10-15 19:04 ` Carlos Pita
2019-10-15 19:45 ` Carlos Pita
2019-10-16 20:18 ` Carlos Pita
2019-10-16 22:07 ` Carlos Pita
2019-10-20 12:21 ` Eli Zaretskii
2019-10-20 15:47 ` Carlos Pita
2019-10-20 16:07 ` Eli Zaretskii
2019-10-20 16:32 ` Carlos Pita
2019-10-26 10:39 ` Eli Zaretskii
2019-10-26 15:46 ` Carlos Pita
2019-10-26 16:03 ` Eli Zaretskii
2019-10-26 16:11 ` Carlos Pita
2019-10-27 14:47 ` Carlos Pita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a7a2gxp0.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=37755@debbugs.gnu.org \
--cc=carlosjosepita@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.