From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37755: Logic in init_fringe_bitmap should be moved to backends (maybe rif->define_fringe_bitmap) Date: Sun, 20 Oct 2019 15:21:37 +0300 Message-ID: <83a79v620e.fsf@gnu.org> References: <83a7a2gxp0.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="188065"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37755@debbugs.gnu.org To: Carlos Pita Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 20 14:23:07 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iMAEl-000mmV-Gm for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Oct 2019 14:23:07 +0200 Original-Received: from localhost ([::1]:33374 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMAEk-0001Ip-0A for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Oct 2019 08:23:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41117) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMADk-0008BG-NK for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2019 08:22:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iMADi-0006oW-Qu for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2019 08:22:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45162) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iMADi-0006oK-NQ for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2019 08:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iMADi-0000mG-HU for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2019 08:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Oct 2019 12:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37755 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37755-submit@debbugs.gnu.org id=B37755.15715741182977 (code B ref 37755); Sun, 20 Oct 2019 12:22:02 +0000 Original-Received: (at 37755) by debbugs.gnu.org; 20 Oct 2019 12:21:58 +0000 Original-Received: from localhost ([127.0.0.1]:53983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMADe-0000lx-9R for submit@debbugs.gnu.org; Sun, 20 Oct 2019 08:21:58 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60119) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMADc-0000lk-H9 for 37755@debbugs.gnu.org; Sun, 20 Oct 2019 08:21:56 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47738) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iMADX-0006hC-Dx; Sun, 20 Oct 2019 08:21:51 -0400 Original-Received: from [176.228.60.248] (port=3357 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iMADU-00081B-OK; Sun, 20 Oct 2019 08:21:49 -0400 In-reply-to: (message from Carlos Pita on Wed, 16 Oct 2019 19:07:26 -0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169802 Archived-At: > From: Carlos Pita > Date: Wed, 16 Oct 2019 19:07:26 -0300 > Cc: 37755@debbugs.gnu.org > > The new change amounts to yet another code simplification and an > overall ~40 reduction in LOCs. Sorry, I think I'm missing something here. It looks like you removed the call to init_fringe_bitmap during dumping, and left its equivalent only in define-fringe-bitmap, is that right? If so, I cannot see how this could work, because Emacs needs to have the standard fringe bitmaps (for line truncation, continuation, etc.) be defined even without a call to define-fringe-bitmap. If you start the current master under a debugger after putting a breakpoint in Fdefine_fringe_bitmap, the breakpoint doesn't break, and yet the bitmaps are known and will be displayed as needed. What did I miss?