all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Wanrong Lin <wrglin@gmail.com>
Cc: 38079@debbugs.gnu.org
Subject: bug#38079: On Windows tramp hangs after server-start is called
Date: Wed, 06 Nov 2019 18:06:02 +0200	[thread overview]
Message-ID: <83a799gfbp.fsf@gnu.org> (raw)
In-Reply-To: <0bf97a5e-549f-1e8a-4212-5b08ad05f049@gmail.com> (message from Wanrong Lin on Tue, 5 Nov 2019 19:52:59 -0500)

> From: Wanrong Lin <wrglin@gmail.com>
> Date: Tue, 5 Nov 2019 19:52:59 -0500
> 
> ;; On Windows, after "server-start" is called, somehow (system-name) 
> will return lower case host name. If the original
> ;; (system-name) returns upper case host name now 
> tramp-restricted-shell-hosts-alist will be out-of-date and cause
> ;; tramp not to function properly.
> (defadvice server-start (after update-restricted-host-list last activate)
>    (setf tramp-restricted-shell-hosts-alist
>          (when (memq system-type '(windows-nt))
>            (list (concat "\\`" (regexp-quote (system-name)) "\\'")))))
> 
> But the proper fix should be to make sure (system-name) always returns 
> the same string consistently. I found it is this sexp in "server-start" 
> function that changes the return value of (system-name):
> 
>        (setq server-process
>          (apply #'make-network-process ....))

Thanks.  However, your proposed solution is very hard to implement
(for boring technical reasons), so my suggestion is for Trump to
compare system names case insensitively, at least on MS-Windows, with
a proper comment to explain why.





  reply	other threads:[~2019-11-06 16:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-06  0:52 bug#38079: On Windows tramp hangs after server-start is called Wanrong Lin
2019-11-06 16:06 ` Eli Zaretskii [this message]
2019-11-06 16:14   ` martin rudalics
2019-11-06 17:37     ` Michael Albinus
2019-11-06 16:50   ` Wanrong Lin
2019-11-06 18:11     ` Eli Zaretskii
2019-11-08  7:51       ` Michael Albinus
2019-11-08 10:34         ` Eli Zaretskii
2019-11-08 10:50           ` Michael Albinus
2019-11-08 13:35             ` Eli Zaretskii
2019-11-07 15:23     ` Michael Albinus
2019-11-07 16:18       ` Wanrong Lin
2019-11-07 17:45         ` Michael Albinus
2019-11-07 16:18       ` Wanrong Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83a799gfbp.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=38079@debbugs.gnu.org \
    --cc=wrglin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.