From: Eli Zaretskii <eliz@gnu.org>
To: larsi@gnus.org, npostavs@users.sourceforge.net
Cc: mvoteiza@udel.edu, npostavs@gmail.com, 28257@debbugs.gnu.org
Subject: bug#28257: 26.0.50; [PATCH] expose eldoc functions in a hook
Date: Sat, 08 Feb 2020 12:03:44 +0200 [thread overview]
Message-ID: <83a75te6pr.fsf@gnu.org> (raw)
In-Reply-To: <838slnlo16.fsf@gnu.org> (message from Eli Zaretskii on Fri, 31 Jan 2020 16:05:09 +0200)
Ping!
Can we please review Mark's patch some time soon? TIA.
> Date: Fri, 31 Jan 2020 16:05:09 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: larsi@gnus.org, 28257@debbugs.gnu.org, npostavs@gmail.com,
> npostavs@users.sourceforge.net
>
> > Date: Sun, 26 Jan 2020 18:47:31 -0500
> > From: Mark Oteiza <mvoteiza@udel.edu>
> > Cc: Lars Ingebrigtsen <larsi@gnus.org>, 28257@debbugs.gnu.org,
> > npostavs@users.sourceforge.net
> >
> > On 26/06/19 at 10:03am, Mark Oteiza wrote:
> > > On 24/06/19 at 06:51pm, Noam Postavsky wrote:
> > > > Lars Ingebrigtsen <larsi@gnus.org> writes:
> > > >
> > > > > Mark Oteiza <mvoteiza@udel.edu> writes:
> > > > >
> > > > >>> Could be a worthwhile tradeoff (especially
> > > > >>>since there currently aren't any individual mode eldoc functions using
> > > > >>>anything apart from :before-until, afaik); I'm on the fence about this.
> > > > >>
> > > > >> Not in emacs, at least. In elpa, ggtags uses :after-until. The only
> > > > >> 3rd party packages--that I can think of right now--that implement eldoc
> > > > >> functions just use setq-local (elpy and geiser).
> > > > >
> > > > > Noam, still on the fence?
> > > >
> > > > I haven't really thought about this much, maybe bring it up on
> > > > emacs-devel?
> > >
> > > I happily rolled with this patch until some changes to eldoc broke it.
> > > Will post a new patch when I get around to it.
> >
> > New patch below. Lightly tested, at first sight it seems to work
> > (setting eldoc-documentation-function to eldoc-documentation-compose)
>
> Lars, Noam, any comments?
>
>
>
>
next prev parent reply other threads:[~2020-02-08 10:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 2:10 bug#28257: 26.0.50; [PATCH] expose eldoc functions in a hook Mark Oteiza
2017-08-28 2:49 ` npostavs
2017-08-28 3:11 ` Mark Oteiza
2017-08-29 1:05 ` npostavs
2017-08-30 1:50 ` Mark Oteiza
2019-06-24 16:16 ` Lars Ingebrigtsen
2019-06-24 22:51 ` Noam Postavsky
2019-06-26 14:03 ` Mark Oteiza
2020-01-26 23:47 ` Mark Oteiza
2020-01-31 14:05 ` Eli Zaretskii
2020-02-08 10:03 ` Eli Zaretskii [this message]
2020-02-11 21:57 ` Noam Postavsky
2020-02-14 9:58 ` Eli Zaretskii
2020-02-14 14:51 ` Stefan Monnier
2020-02-14 14:50 ` Stefan Monnier
2020-02-14 22:54 ` Mark Oteiza
2020-02-21 8:47 ` Eli Zaretskii
2020-02-25 23:18 ` Mark Oteiza
2020-08-10 14:42 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a75te6pr.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=28257@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=mvoteiza@udel.edu \
--cc=npostavs@gmail.com \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.