From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#39980: [PATCH] gnus-shorten-url: Improve and avoid args-out-of-range error Date: Sun, 12 Apr 2020 14:05:40 +0300 Message-ID: <83a73hklq3.fsf@gnu.org> References: <20200308090630.41238-1-stepnem@gmail.com> <87pndf17v5.fsf@gnus.org> <87zhcinbdl.fsf@gmail.com> <87d09ezudv.fsf@gnus.org> <83zhciby6s.fsf@gnu.org> <87imioo963.fsf@gmail.com> <875zeinoc0.fsf@gnus.org> <87wo6lc9n8.fsf@gmail.com> <83blnxkn7i.fsf@gnu.org> <87o8rxc72a.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="117983"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 39980@debbugs.gnu.org To: =?UTF-8?Q?=C5=A0t=C4=9Bp=C3=A1n_?= =?UTF-8?Q?N=C4=9Bmec?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 12 13:06:48 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jNaRs-000Uau-BP for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Apr 2020 13:06:48 +0200 Original-Received: from localhost ([::1]:60696 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jNaRr-0002o8-7l for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Apr 2020 07:06:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48047) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jNaRJ-0002nW-E8 for bug-gnu-emacs@gnu.org; Sun, 12 Apr 2020 07:06:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jNaR9-0007Bh-B0 for bug-gnu-emacs@gnu.org; Sun, 12 Apr 2020 07:06:13 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45904) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jNaR9-0007Bb-7u for bug-gnu-emacs@gnu.org; Sun, 12 Apr 2020 07:06:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jNaR8-00032z-2B for bug-gnu-emacs@gnu.org; Sun, 12 Apr 2020 07:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Apr 2020 11:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39980 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39980-submit@debbugs.gnu.org id=B39980.158668956011706 (code B ref 39980); Sun, 12 Apr 2020 11:06:02 +0000 Original-Received: (at 39980) by debbugs.gnu.org; 12 Apr 2020 11:06:00 +0000 Original-Received: from localhost ([127.0.0.1]:57450 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNaR6-00032i-2o for submit@debbugs.gnu.org; Sun, 12 Apr 2020 07:06:00 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:32857) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNaR3-00032W-PJ for 39980@debbugs.gnu.org; Sun, 12 Apr 2020 07:05:58 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:57357) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jNaQy-00077e-ME; Sun, 12 Apr 2020 07:05:52 -0400 Original-Received: from [176.228.60.248] (port=2013 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jNaQy-0005z7-33; Sun, 12 Apr 2020 07:05:52 -0400 In-Reply-To: <87o8rxc72a.fsf@gmail.com> (message from =?UTF-8?Q?=C5=A0t=C4=9Bp=C3=A1n_?= =?UTF-8?Q?N=C4=9Bmec?= on Sun, 12 Apr 2020 12:49:33 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:178235 Archived-At: > From: Štěpán Němec > Cc: larsi@gnus.org, 39980@debbugs.gnu.org > Date: Sun, 12 Apr 2020 12:49:33 +0200 > > > OK for the change in gnus-summary-browse-url, but let's please leave > > out of emacs-27 changes that aren't necessarily needed to fix the > > original problem; cleanups are for master. > > Understood. > > > On emacs-27, let's just fix the original problem locally. > > The revised patch is upthread > () That's the one I was talking about: it includes changes that aren't needed to fix the original bug. Those additions make the change cleaner, but we are way past cleanup time on the release branch. > There are no changes in the patch that are not necessary for fixing the > problem. The ediff changes (only adjusting callers) are necessitated by > moving the helper function to subr-x.el, so that Gnus (or anything else) > can use it, too. The changes in subr-x and in ediff are unnecessary. Let's make changes only in gnus-summary-browse-url, OK? The full changeset can go to master. Btw, this part of the commit log is inaccurate: * lisp/vc/ediff-init.el (ediff-truncate-string-left): Rename to 'string-truncate-left'. And this one names the wrong function: * lisp/vc/ediff-mult.el (ediff-meta-insert-file-info1) (ediff-draw-dir-diffs): 'ediff-draw-dir-diffs' renamed to 'string-truncate-left'. And finally, the format of the last entry is slightly off the mark. It should look like this: * lisp/vc/ediff-mult.el (ediff-meta-insert-file-info1) (ediff-draw-dir-diffs): That is, the second parentheses pair should be on a new line.