From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#41242: Port feature/native-comp to Windows Date: Wed, 20 May 2020 18:27:16 +0300 Message-ID: <83a7227hkb.fsf@gnu.org> References: <834ksi60zn.fsf@gnu.org> <83k11e4a0s.fsf@gnu.org> <83blmp4tob.fsf@gnu.org> <83o8qp1hfr.fsf@gnu.org> <837dxcv1po.fsf@gnu.org> <83imgvdf94.fsf@gnu.org> <83eerjde6k.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="41201"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41242@debbugs.gnu.org, akrl@sdf.org To: Nicolas =?UTF-8?Q?B=C3=A9rtolo?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 20 17:30:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jbQfb-000AcT-LH for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 May 2020 17:30:11 +0200 Original-Received: from localhost ([::1]:47216 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jbQfa-0005pv-KU for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 May 2020 11:30:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38480) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jbQfS-0005oU-SB for bug-gnu-emacs@gnu.org; Wed, 20 May 2020 11:30:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42486) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jbQfS-0004jq-HB for bug-gnu-emacs@gnu.org; Wed, 20 May 2020 11:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jbQfS-0004Ni-CS for bug-gnu-emacs@gnu.org; Wed, 20 May 2020 11:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 May 2020 15:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41242 X-GNU-PR-Package: emacs Original-Received: via spool by 41242-submit@debbugs.gnu.org id=B41242.158998859916812 (code B ref 41242); Wed, 20 May 2020 15:30:02 +0000 Original-Received: (at 41242) by debbugs.gnu.org; 20 May 2020 15:29:59 +0000 Original-Received: from localhost ([127.0.0.1]:54032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbQfM-0004N2-9P for submit@debbugs.gnu.org; Wed, 20 May 2020 11:29:59 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59164) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbQfK-0004Mo-1J for 41242@debbugs.gnu.org; Wed, 20 May 2020 11:29:55 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51188) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jbQfB-0004Ta-QZ; Wed, 20 May 2020 11:29:46 -0400 Original-Received: from [176.228.60.248] (port=2047 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jbQcn-0001OM-8b; Wed, 20 May 2020 11:27:18 -0400 In-Reply-To: (message from Nicolas =?UTF-8?Q?B=C3=A9rtolo?= on Tue, 19 May 2020 16:25:53 -0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180659 Archived-At: > From: Nicolas BĂ©rtolo > Date: Tue, 19 May 2020 16:25:53 -0300 > Cc: Andrea Corallo , 41242@debbugs.gnu.org > > * lisp/emacs-lisp/comp.el (comp-effective-async-max-jobs): Use > NUMBER_OF_PROCESSORS environment variable if system is Windows NT, > "nproc" if it is in PATH or a default of 1. This shouldn't be necessary: we already have a function to determine the number of processors, see get_native_system_info in w32.c. If you need the result exported to Lisp, we can define a new variable which will be populated with the value. > Subject: [PATCH] Determine the emacs root dir only when necessary. > > * src/fileio.c: Introduce function emacs_root_dir(). Refactor > `expand-file-name` to use it. > * src/lisp.h: Separate emacs_root_dir() into dos_emacs_root_dir() and > w32_emacs_root_dir(). > * src/msdos.c: Rename emacs_root_dir() to dos_emacs_root_dir(). > * src/w32.c: Rename emacs_root_dir() to w32_emacs_root_dir(). Can you explain what problem this solves, and how? It is especially important to understand when will be emacs_root_dir first called during a session. That's because it calls filename_from_ansi, which AFAIR needs some setup that happens at the beginning of a session. Thanks.