From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#44318: 28.0.50; Problem with ispell/flyspell and ""enchant"" backend Date: Tue, 03 Nov 2020 18:45:02 +0200 Message-ID: <83a6vycru9.fsf@gnu.org> References: <83k0v8b1u3.fsf@gnu.org> <83o8ki96m6.fsf@gnu.org> <83k0v6hhzg.fsf@gnu.org> <83h7q8e8ja.fsf@gnu.org> <838sbjepcw.fsf@gnu.org> <83y2jjd9ix.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6295"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dinkonin@gmail.com, 44318@debbugs.gnu.org To: Reuben Thomas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 03 17:46:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kZzRi-0001Tv-Dq for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 03 Nov 2020 17:46:10 +0100 Original-Received: from localhost ([::1]:59874 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZzRh-00011w-Dz for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 03 Nov 2020 11:46:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46432) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZzRa-00010Y-E1 for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2020 11:46:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34679) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kZzRa-0002bi-4F for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2020 11:46:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kZzRa-0005YV-1h for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2020 11:46:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Nov 2020 16:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44318 X-GNU-PR-Package: emacs Original-Received: via spool by 44318-submit@debbugs.gnu.org id=B44318.160442191921296 (code B ref 44318); Tue, 03 Nov 2020 16:46:02 +0000 Original-Received: (at 44318) by debbugs.gnu.org; 3 Nov 2020 16:45:19 +0000 Original-Received: from localhost ([127.0.0.1]:46225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZzQs-0005XQ-RG for submit@debbugs.gnu.org; Tue, 03 Nov 2020 11:45:19 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46106) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZzQr-0005XC-Fs for 44318@debbugs.gnu.org; Tue, 03 Nov 2020 11:45:17 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:46991) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZzQm-0002Bk-1s; Tue, 03 Nov 2020 11:45:12 -0500 Original-Received: from [176.228.60.248] (port=2981 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kZzQl-0003C9-GY; Tue, 03 Nov 2020 11:45:11 -0500 In-Reply-To: (message from Reuben Thomas on Mon, 2 Nov 2020 21:49:33 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192623 Archived-At: > From: Reuben Thomas > Date: Mon, 2 Nov 2020 21:49:33 +0000 > Cc: dinkonin , 44318@debbugs.gnu.org > > 1. Simplify ispell-call-process{,-region} by factoring out the macro ispell-with-safe-default-directory. > > 2. I also found that ispell-check-version can be simplified slightly: aspell has accepted -vv since 2004, so use > it always. > 3. When spell-checking, collect only standard output. This leaves some spell-checker-specific calls to > ispell-call-process to collect stderr as well, which as far as I can tell is needed in only one case, > ispell-find-hunspell-dictionaries; but it doesn't hurt to leave the rest unchanged. I have tested this patch with > all supported spellcheckers (ispell, aspell, hunspell, enchant). I'm okay with the first 2, but I'm less comfortable with the 3rd one. It is wrong to assume that nothing but warnings come through stderr: for example "hunspell -D" emits the important information to stderr, at least on my system. It could be that we don't currently use the 2 functions you suggest to change for such cases, but I think ignoring stderr in some calls and not the others is a slippery slope of confusion and subtle bugs. Since the important case -- that of enchanty-lsmod -- is already solved, why do we need to make changes that are not really required, and currently don't give us any gains? Thanks.