From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH] Fix some failing tests in BSD systems
Date: Sun, 03 Jan 2021 19:35:20 +0200
Message-ID: <83a6tpdiuf.fsf@gnu.org>
References: <m1sg7i7xfl.fsf.ref@yahoo.es> <m1sg7i7xfl.fsf@yahoo.es>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="37562"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-devel@gnu.org
To: Daniel =?iso-8859-1?Q?Mart=EDn?= <mardani29@yahoo.es>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 03 18:36:34 2021
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1kw7Iv-0009fW-QE
	for ged-emacs-devel@m.gmane-mx.org; Sun, 03 Jan 2021 18:36:33 +0100
Original-Received: from localhost ([::1]:45630 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1kw7Iu-0008Be-S1
	for ged-emacs-devel@m.gmane-mx.org; Sun, 03 Jan 2021 12:36:32 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58182)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1kw7Hv-0007RB-Rx
 for emacs-devel@gnu.org; Sun, 03 Jan 2021 12:35:31 -0500
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45794)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1kw7Hv-0004g9-KP; Sun, 03 Jan 2021 12:35:31 -0500
Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3457
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1kw7Hv-0005HO-49; Sun, 03 Jan 2021 12:35:31 -0500
In-Reply-To: <m1sg7i7xfl.fsf@yahoo.es> (message from Daniel
 =?iso-8859-1?Q?Mart=EDn?= on Sun, 03 Jan 2021 18:16:46 +0100)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:262371
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/262371>

> From: Daniel Martín <mardani29@yahoo.es>
> Date: Sun, 03 Jan 2021 18:16:46 +0100
> 
>  (ert-deftest xref--xref-file-name-display-is-abs ()
> -  (let ((xref-file-name-display 'abs))
> -    (should (equal (delete-dups
> -                    (mapcar 'xref-location-group
> -                            (xref-tests--locations-in-data-dir "\\(bar\\|foo\\)")))
> -                   (list
> -                    (concat xref-tests--data-dir "file1.txt")
> -                    (concat xref-tests--data-dir "file2.txt"))))))
> +  (let ((xref-file-name-display 'abs)
> +        ;; BSD find may add an extra '/' to the path.
> +        (expected (list
> +                   (concat xref-tests--data-dir "/?file1.txt")
> +                   (concat xref-tests--data-dir "/?file2.txt")))

Why are we producing file names by concatenation, instead of calling
expand-file-name?  Wouldn't using the latter solve the problem?  Or
what did I miss?