From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50630: [PATCH] Add tests for insert-directory Date: Sat, 25 Sep 2021 09:10:31 +0300 Message-ID: <83a6k1rxrc.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5114"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50630@debbugs.gnu.org To: John Cummings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 25 08:11:40 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mU0uS-0001An-EV for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Sep 2021 08:11:40 +0200 Original-Received: from localhost ([::1]:52746 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mU0uQ-0002dG-Kt for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Sep 2021 02:11:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55322) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mU0tq-0002Ex-Rm for bug-gnu-emacs@gnu.org; Sat, 25 Sep 2021 02:11:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48577) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mU0tq-00037F-39 for bug-gnu-emacs@gnu.org; Sat, 25 Sep 2021 02:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mU0tp-0004i0-Qo for bug-gnu-emacs@gnu.org; Sat, 25 Sep 2021 02:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Sep 2021 06:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50630 X-GNU-PR-Package: emacs Original-Received: via spool by 50630-submit@debbugs.gnu.org id=B50630.163255023918061 (code B ref 50630); Sat, 25 Sep 2021 06:11:01 +0000 Original-Received: (at 50630) by debbugs.gnu.org; 25 Sep 2021 06:10:39 +0000 Original-Received: from localhost ([127.0.0.1]:60123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mU0tT-0004hF-Ic for submit@debbugs.gnu.org; Sat, 25 Sep 2021 02:10:39 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50118) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mU0tS-0004gv-Ef for 50630@debbugs.gnu.org; Sat, 25 Sep 2021 02:10:38 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59894) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mU0tN-0002dc-6G; Sat, 25 Sep 2021 02:10:33 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2203 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mU0tM-0005v7-Pq; Sat, 25 Sep 2021 02:10:33 -0400 In-Reply-To: (message from John Cummings on Fri, 24 Sep 2021 19:58:25 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:215415 Archived-At: > Date: Fri, 24 Sep 2021 19:58:25 +0000 > From: John Cummings > > Along those lines, I also attempted to skip the test when ls-lisp > would be used during files-tests.el, which I predict might happen when > building on Windows? Why did you need to skip those tests? Can you elaborate? > + ;;Try to verify that insert-directory will come from files.el, > + ;;not ls-lisp.el. Windows builds will probably use ls-lisp.el > + ;;by default, which will invalidate some tests. > + (insert-directory-program-used (or (not (featurep 'ls-lisp)) > + ls-lisp-use-insert-directory-program))) I guess this is part of the same question I asked above? Because I don't think I understand what you are trying to do here and why. Thanks.