From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 40dcf9c2ab 4/5: read-multiple-choice: Display "SPC" instead of " " Date: Sun, 26 Dec 2021 20:23:02 +0200 Message-ID: <83a6gnns3d.fsf@gnu.org> References: <83ee5znx7r.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30734"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Dec 26 19:23:35 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n1YBC-0007kk-MJ for ged-emacs-devel@m.gmane-mx.org; Sun, 26 Dec 2021 19:23:34 +0100 Original-Received: from localhost ([::1]:34990 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n1YBB-00054x-I9 for ged-emacs-devel@m.gmane-mx.org; Sun, 26 Dec 2021 13:23:33 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50076) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1YAS-0004P5-Vj for emacs-devel@gnu.org; Sun, 26 Dec 2021 13:22:48 -0500 Original-Received: from [2001:470:142:3::e] (port=33192 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1YAS-0003SE-Fi; Sun, 26 Dec 2021 13:22:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=dfr5gRmx3fhuSkv3vXHrd0PwEimNTavkbNum5ZRdFjw=; b=ElTMv5MFy2xu S000iSCa7GWrqi+VtTNAkO68kei+bAW+Wqb5iCW20AZJ5VNKacUe9rwPsOuzFavgM/PoHfe6wS5bF grc7gO3zqGCxw5O+f7Tg7QMYYyBOUpeH6qqSRpOMAqfr1SRiq/xpmCBqwPzxWs6XPEqS8Zp7JDCaR k2M1xf3+bTb+feaGCmDw1Jvt5L8iyy7Vb18V1imKifemnSHzWntuXO8lD9cEV/YZeR4N1iJbk8uDh KZ11iiBWp2C3vVeVXmfF1pj0/cMCzyTbccYEeSHkCzcp3BPWYUkPJks7PCSOrrV+LW+Hz2Hp0UcsL HWvPceF0SM4uBbWQB3AiNg==; Original-Received: from [87.69.77.57] (port=2392 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1YAS-0007E6-9A; Sun, 26 Dec 2021 13:22:48 -0500 In-Reply-To: (message from Stefan Kangas on Sun, 26 Dec 2021 09:09:15 -0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:283346 Archived-At: > From: Stefan Kangas > Date: Sun, 26 Dec 2021 09:09:15 -0800 > Cc: emacs-devel@gnu.org > > Eli Zaretskii writes: > > > I don't think I like the result of this changeset. Now SPC is > > displayed as [SPC], in brackets, for a reason I cannot understand. > > Before this change, SPC in `read-multiple-choice' was displayed as, for > example > > yes; use once > ^ > > Where the indicated space character was underlined. So this is > much less confusing, I think. (See below regarding the brackets.) I;m not against using "SPC", I only don't like the brackets around it (and around "!" as well). They distract and confuse, IMO. > Though when moving `disabled-command' to use `read-multiple-choice' it > is true that we did lose the explanation in the old prompt that said: > > Type y, n, ! or SPC (the space bar): > > I'm not sure what, if anything we should do about this. One idea is to > explain what SPC means at the bottom of the *Disabled Command* buffer. Why not allow read-multiple-choice to specify longer strings? It already does, with "yes" and "no", doesn't it? > (Personally, I think by the time you stumble upon `disabled-command' you > should already be proficient enough to know what SPC means. No, we need to support the case where the user type "C-n n" by mistake. > > Why is it a good idea to show some of the responses in brackets? I > > say let's remove the brackets altogether, they are not needed, > > especially since the keys are already in a special face. Too many > > features at once are not necessarily a Good Thing. > > I think you have a point regarding these brackets, but note that they > have always been there with `read-multiple-choice'. > > We could remove them, I think, but would they still be needed on > terminals that can't display underline? Or should we perhaps just use > help-key-binding in that case? I think having the keys/responses in a special face, even if it's without the underline, should be enough. The face should provide alternatives for the underline, such as distinct colors.