all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: master 4df7bb9c01 2/2: Fix display of stretch glyphs when hscrolled on PGTK
Date: Fri, 04 Mar 2022 14:06:36 +0200	[thread overview]
Message-ID: <83a6e5j50z.fsf@gnu.org> (raw)
In-Reply-To: <mailman.7333.1646390109.1056.emacs-diffs@gnu.org> (emacs-diffs-request@gnu.org)

The resulting code after this changeset seems to test some conditions
twice:

>        if (x < text_left_x && !s->row->mode_line_p)
>  	{
> -	  int left_x = WINDOW_LEFT_SCROLL_BAR_AREA_WIDTH (s->w);
> -	  int right_x = text_left_x;
> +	  int background_width = s->background_width;
> +	  int x = s->x, text_left_x = window_box_left (s->w, TEXT_AREA);
>  
> -	  if (WINDOW_HAS_FRINGES_OUTSIDE_MARGINS (s->w))
> -	    left_x += WINDOW_LEFT_FRINGE_WIDTH (s->w);
> -	  else
> -	    right_x -= WINDOW_LEFT_FRINGE_WIDTH (s->w);
> -
> -	  /* Adjust X and BACKGROUND_WIDTH to fit inside the space
> -	     between LEFT_X and RIGHT_X.  */
> -	  if (x < left_x)
> +	  /* Don't draw into left fringe or scrollbar area except for
> +	     header line and mode line.  */
> +	  if (s->area == TEXT_AREA
> +	      && x < text_left_x && !s->row->mode_line_p)
>  	    {

The 'if (x < text_left_x && !s->row->mode_line_p)' condition is tested
again inside the block conditioned on that.  Is that necessary?



       reply	other threads:[~2022-03-04 12:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mailman.7333.1646390109.1056.emacs-diffs@gnu.org>
2022-03-04 12:06 ` Eli Zaretskii [this message]
2022-03-04 12:37   ` master 4df7bb9c01 2/2: Fix display of stretch glyphs when hscrolled on PGTK Po Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83a6e5j50z.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.