From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#54470: 29.0.50; [PATCH] Add documentation/tests for Eshell argument expansion Date: Sat, 16 Apr 2022 13:30:24 +0300 Message-ID: <83a6cl1fsv.fsf@gnu.org> References: <83bky1f6jk.fsf@gnu.org> <83k0ca7fo6.fsf@gnu.org> <83zgkm1p4v.fsf@gnu.org> <25d222b3-9633-708e-6ac7-568c7a89e806@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2494"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 54470@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 16 12:32:44 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nffjQ-0000VI-AI for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 Apr 2022 12:32:44 +0200 Original-Received: from localhost ([::1]:40764 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nffjO-0003bG-Te for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 Apr 2022 06:32:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40404) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nffhn-00028S-6D for bug-gnu-emacs@gnu.org; Sat, 16 Apr 2022 06:31:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38637) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nffhm-0006wa-0c for bug-gnu-emacs@gnu.org; Sat, 16 Apr 2022 06:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nffhl-0007T2-RD for bug-gnu-emacs@gnu.org; Sat, 16 Apr 2022 06:31:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Apr 2022 10:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54470 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54470-submit@debbugs.gnu.org id=B54470.165010503928676 (code B ref 54470); Sat, 16 Apr 2022 10:31:01 +0000 Original-Received: (at 54470) by debbugs.gnu.org; 16 Apr 2022 10:30:39 +0000 Original-Received: from localhost ([127.0.0.1]:60767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nffhP-0007SS-8G for submit@debbugs.gnu.org; Sat, 16 Apr 2022 06:30:39 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47010) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nffhN-0007SF-Ji for 54470@debbugs.gnu.org; Sat, 16 Apr 2022 06:30:37 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58874) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nffhH-0006t7-OQ; Sat, 16 Apr 2022 06:30:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=2faD9GSBITYSPge1XkQdn7APRxsDqMouSvw3xYMJwwQ=; b=TGEPKHdu9OCc /9wdMTCrJ4McJlb2Ukl+oJ6IxUKGj6AdEHjjE+tHIsPiNrd3R7iAXSlM2fkc1ohr1wHoLkv8HBZ2L /q7YziFW+4WbCNm9CZJCESTAVPVphEvHt/I90rdza9r0nWKG0gfxOZDEX+pd4Vd2aapbdq6/eJi/J FmA6xMF/P9FHs8Hi29Ku+t2G8PhRz6LgqHsJfsmK7uOg74DquGaRHhb0kszuc6HtpTAZ2VcZigmTt xVd2gaE0zljvWe7d0CdG6AO5onXiLWA1aVwnk6xmKsLXhl7MoSTmCntbftPT0pGnjcXtexcikQX65 MDVRjIliZXxi+eHqj6aTDA==; Original-Received: from [87.69.77.57] (port=1986 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nffgw-0000CT-6D; Sat, 16 Apr 2022 06:30:13 -0400 In-Reply-To: <25d222b3-9633-708e-6ac7-568c7a89e806@gmail.com> (message from Jim Porter on Fri, 15 Apr 2022 21:57:02 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:229970 Archived-At: > Cc: 54470@debbugs.gnu.org > From: Jim Porter > Date: Fri, 15 Apr 2022 21:57:02 -0700 > > On 4/15/2022 5:56 AM, Eli Zaretskii wrote: > >> Cc: 54470@debbugs.gnu.org > >> From: Jim Porter > >> Date: Fri, 1 Apr 2022 22:10:07 -0700 > >> > >>> @kbd is right for things that are meant specifically and only as > >>> keyboard input. > >> > >> Thanks for the explanation. > >> > >> Having thought this over further, I think Eli's suggestion to use @samp > >> makes sense for both the globs and the predicates/modifiers, so I've > >> updated my patches to do this. > > > > Thanks. I was about to install these, but then I saw that some of > > the tests you added fail on my system: > [snip] > > Thanks for testing. I think this is because `eshell-file-attributes' > calls `expand-file-name' on the FILE argument, which prepends a drive > letter on MS Windows. That makes my code in `eshell-partial-let-func' > (in em-pred-tests.el) fail to identify the fake files. > > Can you try the attached patch to see if the tests pass? If it works, > I'll fold it into the previous patches and resubmit them. (It works for > me on an MS Windows system, but I don't have build tools on it, so I > just used the binary release of 28.1 with some of the bits copied from > my patches to test it out.) Yes, this fixes the failures, thanks.