From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: pquessev@gmail.com, larsi@gnus.org, 58464@debbugs.gnu.org
Subject: bug#58464: 28.1; browse-url-emacs doesn't work for local files on Windows
Date: Thu, 13 Oct 2022 22:15:45 +0300 [thread overview]
Message-ID: <83a65za61q.fsf@gnu.org> (raw)
In-Reply-To: <6cc4566c-00f8-8fa1-4dcd-411539972f87@cs.ucla.edu> (message from Paul Eggert on Thu, 13 Oct 2022 09:40:54 -0700)
> Date: Thu, 13 Oct 2022 09:40:54 -0700
> Cc: pquessev@gmail.com, 58464@debbugs.gnu.org
> From: Paul Eggert <eggert@cs.ucla.edu>
>
> >> - if (NILP (handler) && !NILP (visit) && current_buffer->modtime.tv_nsec < 0)
> >> + if (save_errno != 0)
> >>
> >> might cause us signal an error when VISIT is nil, something that
> >> didn't happen before.
>
> We should be OK there. If VISIT is nil, SAVE_ERRNO must be zero.
>
> >> (I also am not sure it is 100% reliable to rely on save_errno being
> >> non-zero whenever we encounter an error, especially in the
> >> file-handlers case.)
>
> Should be OK here too. In the file-handlers case, SAVE_ERRNO is zero.
Famous last words.
prev parent reply other threads:[~2022-10-13 19:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 6:43 bug#58464: 28.1; browse-url-emacs doesn't work for local files on Windows Pascal Quesseveur
2022-10-12 7:26 ` Eli Zaretskii
2022-10-12 11:10 ` Lars Ingebrigtsen
2022-10-12 13:14 ` Eli Zaretskii
[not found] ` <828rlll4ef.fsf@gmail.com>
2022-10-12 13:04 ` Eli Zaretskii
2022-10-12 11:09 ` Lars Ingebrigtsen
2022-10-12 13:13 ` Eli Zaretskii
2022-10-12 13:18 ` Lars Ingebrigtsen
2022-10-12 14:25 ` Eli Zaretskii
2022-10-12 14:42 ` Lars Ingebrigtsen
2022-10-12 15:55 ` Eli Zaretskii
2022-10-12 15:57 ` Lars Ingebrigtsen
2022-10-12 16:07 ` Eli Zaretskii
2022-10-13 7:54 ` Lars Ingebrigtsen
2022-10-13 10:29 ` Eli Zaretskii
2022-10-13 11:30 ` Lars Ingebrigtsen
2022-10-13 15:44 ` Eli Zaretskii
2022-10-13 16:40 ` Paul Eggert
2022-10-13 19:15 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a65za61q.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=58464@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=larsi@gnus.org \
--cc=pquessev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.