all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: casouri@gmail.com, rpluim@gmail.com, emacs-devel@gnu.org
Subject: Re: Stylistic changes to tree-sitter code
Date: Sat, 29 Oct 2022 11:16:53 +0300	[thread overview]
Message-ID: <83a65fhwne.fsf@gnu.org> (raw)
In-Reply-To: <87sfj72ism.fsf@yahoo.com> (message from Po Lu on Sat, 29 Oct 2022 15:25:13 +0800)

> From: Po Lu <luangruo@yahoo.com>
> Cc: casouri@gmail.com,  rpluim@gmail.com,  emacs-devel@gnu.org
> Date: Sat, 29 Oct 2022 15:25:13 +0800
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > That is correct, but your change removed only "we", and left "I"
> > intact.  In any case, rephrasing to avoid pronouns doesn't necessarily
> > force us to use passive voice.
> 
> Well, if you can, please suggest some better ways to do that.

Compliance!

> -   - It doesn't expose a syntax tree.  We put the syntax tree in the
> -     parser object, and updating the tree is handled on the C level.
> +   - It doesn't expose a syntax tree.  The syntax tree is placed in
> +     the parser object, and updating the tree is handled at the C
> +     level.

Here I'd suggest

  It doesn't expose a syntax tree.  The syntax tree is part of the
  parser object, and updating the tree is handled on the C level.

> -   - We don't expose tree cursor either.  I think Lisp is slow enough
> -     to nullify any performance advantage of using a cursor, though I
> -     don't have evidence.  Also I want to minimize the number of new
> -     types we introduce.  Currently we only add parser and node type.
> +   - The tree cursor is not exposed either.  I think Lisp is slow
> +     enough to nullify any performance advantage of using a cursor,
> +     though I don't have evidence.  Also I want to minimize the number
> +     of new types we introduce.  Currently we only add parser and node
> +     type.

Here I'd suggest

  It doesn't expose the tree cursor, either.  Presumably, Lisp is slow
  enough to make insignificant any performance advantages from using
  the cursor.  Not exposing the cursor also minimizes the number of
  new types this adds to Emacs Lisp; currently, this adds only the
  parser and node types.



  reply	other threads:[~2022-10-29  8:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87h6zp75nt.fsf.ref@yahoo.com>
2022-10-27 13:33 ` Stylistic changes to tree-sitter code Po Lu via Emacs development discussions.
2022-10-27 13:56   ` Robert Pluim
2022-10-28  0:41     ` Po Lu via Emacs development discussions.
2022-10-28  4:14       ` Yuan Fu
2022-10-28  7:03       ` Robert Pluim
2022-10-28  7:08         ` Po Lu
2022-10-29  2:45           ` Po Lu via Emacs development discussions.
2022-10-29  4:19             ` Yuan Fu
2022-10-29  5:44               ` Po Lu
2022-10-29  7:01                 ` Eli Zaretskii
2022-10-29  7:25                   ` Po Lu
2022-10-29  8:16                     ` Eli Zaretskii [this message]
2022-10-29  8:34                       ` Po Lu
2022-10-29  6:54               ` Eli Zaretskii
2022-10-29  7:29               ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83a65fhwne.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=casouri@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.