From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master d0a66f3e0e: Display a warning for some uses of nil in face attributes. Date: Sun, 27 Nov 2022 20:39:21 +0200 Message-ID: <83a64cp7hi.fsf@gnu.org> References: <166215065969.27647.10737851450469499017@vcs2.savannah.gnu.org> <20220902203100.0C8D8C0088A@vcs2.savannah.gnu.org> <3d2972a5f544f212c6c6@heytings.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9390"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gregory@heytings.org, emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 27 19:39:36 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ozMYx-0002Ic-LD for ged-emacs-devel@m.gmane-mx.org; Sun, 27 Nov 2022 19:39:35 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ozMYJ-0005HD-UI; Sun, 27 Nov 2022 13:38:55 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozMYI-0005H2-As for emacs-devel@gnu.org; Sun, 27 Nov 2022 13:38:54 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozMYH-000333-VR; Sun, 27 Nov 2022 13:38:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=YD+hqfrfeiOaZTypjzEvY8PsKeML2MqP/o/SkXvObRA=; b=nnkK30lURLob p9NiioduvUj/Orv8HgIQzh3qwrm8mZGfhGBNYVEnN1OepNEF4gON1+TQfa2MFR1RRyVG/5DbnmhTe OZhKNmfMioo77pAogw81mutI3C3UuMzDzgZXa402x7zxR73vj+PXEAhR6VlCSCFki7V5CEw6Jdkn2 tjceJFIt6JPk3Mu5EyMDwkdb13shovyaIGD/U0Ys5E4/Sk6uUvnjCOD5XvtVWZxOuvFs9AST22xty X/npFTZZLdZH+qE0uWqTyVdRC+C4IRptUVHdvgc6EvyjVXcUPw8B7LtQv1ZuAmss63J1V+FGok/hU S5wEi/R0KgjZOWnc965ApQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozMYH-00052A-CE; Sun, 27 Nov 2022 13:38:53 -0500 In-Reply-To: (message from Stefan Kangas on Sun, 27 Nov 2022 10:20:05 -0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300638 Archived-At: > From: Stefan Kangas > Date: Sun, 27 Nov 2022 10:20:05 -0800 > Cc: emacs-devel@gnu.org > > Gregory Heytings writes: > > > It's not a macro for performance reasons, it's a macro because it didn't > > seem worth to me to make it a function. > > I don't follow your reasoning here. I would make it into a function > unless there is some specific reason to make it into a macro. It's the other way around: a function comes with the call overhead, so it cannot be the default.