From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59935: 29.0.60; project-list-buffers is slow Date: Sun, 11 Dec 2022 20:08:59 +0200 Message-ID: <83a63tu81w.fsf@gnu.org> References: <86a63vi2lu.fsf@mail.linkov.net> <4a78ffcc-15fb-27ac-48b9-82fe84c596aa@yandex.ru> <86bko9na29.fsf@mail.linkov.net> <83bko9u8yy.fsf@gnu.org> <86edt5lt87.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4256"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59935@debbugs.gnu.org, dgutov@yandex.ru To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 11 19:10:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4QmB-0000tj-L4 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Dec 2022 19:10:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4Qm6-0007Zr-4R; Sun, 11 Dec 2022 13:10:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4Qm3-0007Zi-7I for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 13:10:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4Qm2-0001jy-Qa for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 13:10:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p4Qm2-0001LT-At for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 13:10:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Dec 2022 18:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs Original-Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.16707821515156 (code B ref 59935); Sun, 11 Dec 2022 18:10:02 +0000 Original-Received: (at 59935) by debbugs.gnu.org; 11 Dec 2022 18:09:11 +0000 Original-Received: from localhost ([127.0.0.1]:47451 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4QlC-0001L4-Vn for submit@debbugs.gnu.org; Sun, 11 Dec 2022 13:09:11 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4QlB-0001Kx-Dl for 59935@debbugs.gnu.org; Sun, 11 Dec 2022 13:09:09 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4Ql5-0001ea-BH; Sun, 11 Dec 2022 13:09:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=4KlbY1vxjTskctnC8VGQPU17F5X9Z5nE0wMHlrF4uCA=; b=mvfJwu6IGYFS 5panu0Jp0dF+nOG/j3bF8PKzXA/BJNk7dX/joJqNhLYyX0oOgS74H1cwtfaKaw4oN8Hw4k58REU1I o8wuAN9mUibfqIaOjhjVSmzI6tv0ethyLao/6MqJqHo7NcF+HcvcM/0OorB6t4Bi0zpcqElULGZDt nS93nd8/uKKElf21amcH5Ak7X8eQRvCI0lR5dPvwN1aMNT3SJZATHTligrpsQ3nBFf51xY5gY1Ld+ OPGU1ajvD1cGT0Q00YVOt4mOBX9H9L2zijc/g16V4IoKuhw8rNqpignU6Xts3grwRN83PI7S8wXUU X3kVWrtr5EfCu18Mh560ZA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4Ql4-0008OB-KN; Sun, 11 Dec 2022 13:09:02 -0500 In-Reply-To: <86edt5lt87.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 11 Dec 2022 19:56:24 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250639 Archived-At: > From: Juri Linkov > Cc: dgutov@yandex.ru, 59935@debbugs.gnu.org > Date: Sun, 11 Dec 2022 19:56:24 +0200 > > >> > Do you have the time to finish the fix yourself? It was your feature, after > >> > all. > >> > >> Here is a complete patch tested for all possible cases: > >> - emacs 28/29 > >> - with/without file arg > >> - with/without reverting > > > > Thanks, but I hope you don't intend to ask to install this on the > > release branch. And changing back the signature of > > list-buffers-noselect is extremely problematic, even though we changed > > it only for Emacs 29. > > > > Please try to find a safer, more compatible solution. > > This is the safest solution for the emacs-29 branch. I don't see how it could be the safest. For example, an almost identical changeset that doesn't change the signature of list-buffers-noselect is definitely safer. And likewise with the change of list-buffers--refresh -- why do we have to do that?