From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59559: 28.1; `minibuffer-with-setup-hook' with :append Date: Sat, 21 Jan 2023 21:23:24 +0200 Message-ID: <83a62blmj7.fsf@gnu.org> References: <87pmbmnvdd.fsf@web.de> <87358iuqsj.fsf@web.de> <87edro6jl7.fsf@web.de> <83h6wjlx3f.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="413"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael_heerdegen@web.de, 59559@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 21 20:39:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pJJhx-000AUI-9c for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 21 Jan 2023 20:39:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pJJTA-0005Vc-BE; Sat, 21 Jan 2023 14:24:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJJT8-0005SK-Gw for bug-gnu-emacs@gnu.org; Sat, 21 Jan 2023 14:24:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pJJT8-0006UC-7h for bug-gnu-emacs@gnu.org; Sat, 21 Jan 2023 14:24:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pJJT8-0004JZ-4h for bug-gnu-emacs@gnu.org; Sat, 21 Jan 2023 14:24:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Jan 2023 19:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59559 X-GNU-PR-Package: emacs Original-Received: via spool by 59559-submit@debbugs.gnu.org id=B59559.167432901116523 (code B ref 59559); Sat, 21 Jan 2023 19:24:02 +0000 Original-Received: (at 59559) by debbugs.gnu.org; 21 Jan 2023 19:23:31 +0000 Original-Received: from localhost ([127.0.0.1]:49805 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJJSc-0004IP-Jj for submit@debbugs.gnu.org; Sat, 21 Jan 2023 14:23:30 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53938) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJJSa-0004I8-IR for 59559@debbugs.gnu.org; Sat, 21 Jan 2023 14:23:29 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJJSU-00063W-T6; Sat, 21 Jan 2023 14:23:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=9dk6a+TUp3akU2tvDPZ5lZHyfavtJULVxBhdAkoLLJg=; b=dnOirjHdi3siPj5rU/z4 zyCnLWmsRtJfPuNSmELcaT8jNZ2mC9VfBh4PkmPREKdKblU60N7LJsItwZrMa/9T5DLq3y6qoVdOO fvc7qOWTVKc0XjhM3CpqrAQ2kHCw4+tnQ85BRclhrTD2KRdOC8hd25mj9GqKRbzhHAk7bRfzPavs0 EujIR3QysI/CV6PnefVYlKafmxjbL0uZKeBlXWGoyf8+fKLwsZPwFbYtwpxY4A+TZDyZIbLEJoff9 purqzZdhLtnxKil5NHs+ywPoQGPl9EvTabkxPO++mcdk23KzuM5wpKXgZ7KCNYwhCZmPmqjZVp/PZ vGPEWxr9NpVJJA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJJSU-0003cc-9Q; Sat, 21 Jan 2023 14:23:22 -0500 In-Reply-To: (message from Drew Adams on Sat, 21 Jan 2023 18:51:25 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253884 Archived-At: > From: Drew Adams > CC: "59559@debbugs.gnu.org" <59559@debbugs.gnu.org> > Date: Sat, 21 Jan 2023 18:51:25 +0000 > > > How about just adding the obvious to the first sentence: > > > > Temporarily add function FUN to `minibuffer-setup-hook' while executing > > BODY. > > To me, that doesn't help at all. And as you would > (usually) say, "function FUN" can just be replaced > by "FUNCTION" there. That's a tangent. Let's keep our focus where it belongs. > Just saying that the first arg is a function doesn't > solve the problem. What is the first arg, exactly? > Is it evaluated? How is this different from the below: expand-file-name is a built-in function in ‘C source code’. (expand-file-name NAME &optional DEFAULT-DIRECTORY) Convert filename NAME to absolute, and canonicalize it. [...] NAME should be a string [...] Since when do we ask about function's arguments whether they are evaluated or not? and why for that particular function and not for others? > It's a sexp. Either that sexp is a list `(:append F)', > in which case only F is evaluated, to provide the > function to add (append), or the entire FUN sexp is > evaluated to provide the function to add (prepend). You are splitting hair. Once again, saying that an argument can (or should) be of some form is a paradigm we use a lot in our doc strings, and this case is not different. > It's this unusual behavior that needs to be understood, > and thus described - in particular pointing out that > the arg isn't just evaluated to begin with. No, it isn't unusual. > > All the rest sounds clear to me, and I find the original text less > > confusing than your proposed change ("expression that should evaluate > > to a function"?). > > Please see the text suggestions I proposed. Somehow > we need to get across the unusual treatment of the > first arg. It isn't unusual. I see nothing here that needs some special wording. And let's not make this another endless discussion where you refuse to accept the judgment of others.