From: Eli Zaretskii <eliz@gnu.org>
To: me@elken.dev
Cc: 61411-done@debbugs.gnu.org
Subject: bug#61411: [PATCH] Handle a case where url-basic-auth can crash
Date: Thu, 02 Mar 2023 14:37:12 +0200 [thread overview]
Message-ID: <83a60ve3d3.fsf@gnu.org> (raw)
In-Reply-To: <7d66200bf9f7541a75484418fa3474ac@elken.dev> (me@elken.dev)
> Date: Sun, 26 Feb 2023 08:52:31 +0000
> From: me@elken.dev
> Cc: 61411@debbugs.gnu.org
>
> Thanks for responding; I incorrectly assumed because the patch was so
> trivial my description was enough. My bad!
>
> Below is a snippet of elisp that when `M-x eval-buffer`'d crashes an
> `emacs -Q` and causes an `emacs -Q -l repro.el` to freeze indefinitely
> on e444115d026c809395d4d248a99bb467bc87bb1d
>
> (require 'url)
> (eval-when-compile (require 'cl-lib))
>
> (cl-defun send-request (endpoint &key verb data headers noninteractive
> json noauth sync callback)
> (let* ((url-request-method (or verb "GET"))
> (url-cookie-trusted-urls '(".*"))
> (url-request-noninteractive noninteractive)
> (url-request-extra-headers
> `(("Referer" . ,endpoint)
> ("X-CSRF-TOKEN" . nil)
> ("Cookie" . nil)))
> (url-request-data data))
> (if sync
> (with-current-buffer (url-retrieve-synchronously endpoint)
> (funcall (or callback #'identity) url-http-response-status))
> (url-retrieve
> endpoint
> (or callback #'identity)))))
>
> (send-request "https://httpstat.us/401" :noninteractive t :sync t)
>
> The linked API is a simple service used to return various status codes,
> in this instance always a 401 regardless of what authentication is
> passed.
>
> I'm not sure if my patch is the best catch-all solution to the
> underlying issue (I confess, I don't fully understand why this crashes).
> With my simple patch applied though, Emacs continues as expected.
>
> I hope this is enough information now, I apologize for the poor initial
> report. As I already had a patch ready, I didn't think I should have
> used `M-x report-emacs-bug` but I will in future :)
Thanks, I fixed this in a slightly different manner on the emacs-29
branch, and I'm therefore closing this bug.
prev parent reply other threads:[~2023-03-02 12:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-11 7:43 bug#61411: [PATCH] Handle a case where url-basic-auth can crash me--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-25 21:36 ` me--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-26 5:29 ` Eli Zaretskii
2023-02-26 8:52 ` me--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-02 12:37 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a60ve3d3.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=61411-done@debbugs.gnu.org \
--cc=me@elken.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.