From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62086: 29.0.60; ruby-ts-mode regressions Date: Wed, 12 Apr 2023 10:30:51 +0300 Message-ID: <83a5zd8slw.fsf@gnu.org> References: <86y1o5op2v.fsf@mail.linkov.net> <5abcf765-f8ce-9563-63aa-20c558409898@yandex.ru> <86cz4l7zjk.fsf@mail.linkov.net> <86ttxww12o.fsf@mail.linkov.net> <865yaakfs7.fsf@mail.linkov.net> <0bd5f2b8-6f0b-09d6-6240-38c742eca19f@yandex.ru> <861qkyfg8l.fsf@mail.linkov.net> <9ceb589f-9325-1607-d1b5-5fd56cb8c3ec@yandex.ru> <86y1myxsrq.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7781"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62086@debbugs.gnu.org, casouri@gmail.com, theo@thornhill.no, juri@linkov.net To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 12 09:31:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pmUwt-0001s3-VF for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 Apr 2023 09:31:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pmUwd-000175-UI; Wed, 12 Apr 2023 03:31:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmUwZ-0000zP-Ff for bug-gnu-emacs@gnu.org; Wed, 12 Apr 2023 03:31:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pmUwY-0005HP-MH for bug-gnu-emacs@gnu.org; Wed, 12 Apr 2023 03:31:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pmUwY-0001nm-0k for bug-gnu-emacs@gnu.org; Wed, 12 Apr 2023 03:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Apr 2023 07:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62086 X-GNU-PR-Package: emacs Original-Received: via spool by 62086-submit@debbugs.gnu.org id=B62086.16812846206873 (code B ref 62086); Wed, 12 Apr 2023 07:31:01 +0000 Original-Received: (at 62086) by debbugs.gnu.org; 12 Apr 2023 07:30:20 +0000 Original-Received: from localhost ([127.0.0.1]:38882 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pmUvr-0001mm-Pp for submit@debbugs.gnu.org; Wed, 12 Apr 2023 03:30:20 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45666) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pmUvp-0001mZ-De for 62086@debbugs.gnu.org; Wed, 12 Apr 2023 03:30:19 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmUvi-00057x-Dd; Wed, 12 Apr 2023 03:30:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=pOrDFKljjSD1hnyo1o+2y7k6iHkDjVa+LjAYGjnKZUM=; b=bPWsjNp9xy8R GB2gdjDiMGVuv8WKd7771whxZUZH57f0Oea9tL7u6Ezi7v6sM3FMUPJOatQn77gIyGRQ73Lu5xpXt AJZKl9mUUd/22SWy/QDuUcrw2gx18KMUPlM4k386sGxRE8X7wS001VCUq/RLtRsdWfmgso2xW+7+t iKXk2rh6rWAJuvBsyHggHXnpJnlvEETk1Cr11bQyol5+zppDczPZagq34yHrPMgOK8lpSL8K8VMYf zjpr8BkP/vBDLTHzaUUcxsYsj46BjM2VqLYg2RKf+ZHVNiRCw6WOwYaCw5ikSy5CmUx+c+fvUf6go krajTPBShLuEPUazUKdowQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmUvf-0003s6-AG; Wed, 12 Apr 2023 03:30:09 -0400 In-Reply-To: (message from Dmitry Gutov on Wed, 12 Apr 2023 02:30:19 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259701 Archived-At: > Cc: 62086@debbugs.gnu.org, Yuan Fu , > Theodor Thornhill > Date: Wed, 12 Apr 2023 02:30:19 +0300 > From: Dmitry Gutov > > On 11/04/2023 19:53, Juri Linkov wrote: > > I don't know if opening a new bug report is needed. > > Actually I'm doing the same thing for more ts-modes - > > trying to find a set of node names that match parens/brackets. > > So maybe this patch makes sense too: > > These look sensible to me. > > I think we should give a chance to the authors to chime in, though. > > > treesit-sexp-type-regexp.patch > > > > diff --git a/lisp/progmodes/c-ts-mode.el b/lisp/progmodes/c-ts-mode.el > > index d773b4a41f4..e55d26177af 100644 > > --- a/lisp/progmodes/c-ts-mode.el > > +++ b/lisp/progmodes/c-ts-mode.el > > @@ -927,7 +927,9 @@ c-ts-base-mode > > "qualifier" > > "type" > > "parameter" > > - "expression" > > + ;; "expression" > > + "argument_list" > > + "identifier" > > "literal" > > "string"))) Can someone please tell which problem(s) this is supposed to fix, and on what branch? This bug report has "29.0.60" in the title, but it starts with describing what happens on master. On the emacs-29 branch C-M-f doesn't use treesit capabilities, at least not in c-ts-mode. So I'm confused regarding the scope and the purpose of this proposal.