From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63757: 29.0.91 order of package paths changed: random old versions of packages in load-path Date: Sun, 04 Jun 2023 18:20:02 +0300 Message-ID: <83a5xf5k65.fsf@gnu.org> References: <83y1l7gzqw.fsf@gnu.org> <87ilcb2p1l.fsf@posteo.net> <87sfb8g85v.fsf@posteo.net> <83a5xf7pi5.fsf@gnu.org> <87ttvnoehl.fsf@posteo.net> <8335377iyo.fsf@gnu.org> <87h6rnoa8v.fsf@posteo.net> <83v8g35ybo.fsf@gnu.org> <87cz2bo3qu.fsf@posteo.net> <83pm6b5t1i.fsf@gnu.org> <878rczo28v.fsf@posteo.net> <83o7lv5sjc.fsf@gnu.org> <874jnno1bi.fsf@posteo.net> <83mt1f5rab.fsf@gnu.org> <87zg5fmkgk.fsf@posteo.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25755"; mail-complaints-to="usenet@ciao.gmane.io" Cc: artscan@list.ru, 63757@debbugs.gnu.org, philipk@posteo.net To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 04 17:20:33 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q5pWx-0006TQ-WC for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Jun 2023 17:20:32 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q5pWV-0001P6-M2; Sun, 04 Jun 2023 11:20:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5pWU-0001O0-Ak for bug-gnu-emacs@gnu.org; Sun, 04 Jun 2023 11:20:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q5pWU-0007c0-0d for bug-gnu-emacs@gnu.org; Sun, 04 Jun 2023 11:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q5pWT-0004zp-SS for bug-gnu-emacs@gnu.org; Sun, 04 Jun 2023 11:20:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Jun 2023 15:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63757 X-GNU-PR-Package: emacs Original-Received: via spool by 63757-submit@debbugs.gnu.org id=B63757.168589196319047 (code B ref 63757); Sun, 04 Jun 2023 15:20:01 +0000 Original-Received: (at 63757) by debbugs.gnu.org; 4 Jun 2023 15:19:23 +0000 Original-Received: from localhost ([127.0.0.1]:46917 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5pVr-0004x7-2t for submit@debbugs.gnu.org; Sun, 04 Jun 2023 11:19:23 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57138) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5pVn-0004wJ-45 for 63757@debbugs.gnu.org; Sun, 04 Jun 2023 11:19:21 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5pVe-0007UG-KU; Sun, 04 Jun 2023 11:19:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=GSk7Ingo6i1EkSt7mvWPISIn/BqQl0sDIEBOmoXt4Y8=; b=n5BQn8Bd5r4h zCiUuvMS5bJBpUdQ9Hu3H++8SunFklrQALkko73ION/u3YxHO7/rvxYDeb06Shko8FTbCDmJAka3o rdEHIteV/mNCsX+vBmgV2OS4fjgd7uXcH3GA68OXTgoggqeqJAJ6kWYzZeB5TEFnL6eOyWf+KPmVd 0d3jdhq+ndAhj28L7rsqwepd6Wgih4ruV/Ia7PzJA7QebB6eys5bUpmhPMbIEQj2xr+9/nakKtw2v lPeaSkaj+tfV2rMArR+UyxDlmFHW3L7sJRfcQHWT9QXxvZh3xYDLrsOTeTBDrLEsg9tuLb0QOoVwQ 0nyL5yR7x8148HZmGoAQPw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5pVd-0001aB-Pj; Sun, 04 Jun 2023 11:19:10 -0400 In-Reply-To: (message from Stefan Monnier on Sun, 04 Jun 2023 11:12:31 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262965 Archived-At: > From: Stefan Monnier > Cc: Philip Kaludercic , Eli Zaretskii , > 63757@debbugs.gnu.org > Date: Sun, 04 Jun 2023 11:12:31 -0400 > > Sounds about right. Except: > > - We still need a `copy-sequence` to avoid `sort` side-effecting the > `package-alist` contents. > - I'm not sure the change of `package-disabled-p` => > `package-built-in-p` is right: it makes the code obey the comment, but > I don't think we want to prefer built-in packages. > > With these two tweaks, I suspect it might actually really fix the bug in > a way that should be safe enough for `emacs-29`. I'd need to see the actual patch, but right now I'm inclined to leave this problem unsolved in Emacs 29. It only happens for people who don't uninstall older versions of packages they install, and that's not the workflow we support in Emacs 29. The offending code was with us since Aug 2022, so replacing it with something at the last moment needs a very good reason.