From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64596: 30.0.50; On FIXME: in src/buffer.c:1481 (force-mode-line-update) Date: Sat, 15 Jul 2023 22:28:39 +0300 Message-ID: <83a5vxas9k.fsf@gnu.org> References: <877cr4nez9.fsf@localhost> <83lefj4okb.fsf@gnu.org> <83fs5r3tqv.fsf@gnu.org> <834jm6fppc.fsf@gnu.org> <87a5vyidy6.fsf@localhost> <83sf9qe2ip.fsf@gnu.org> <83a5vxejz6.fsf@gnu.org> <83r0p9b3om.fsf@gnu.org> <83jzv1b152.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22839"; mail-complaints-to="usenet@ciao.gmane.io" Cc: yantar92@posteo.net, 64596@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 15 21:29:29 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qKkxN-0005lT-LE for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Jul 2023 21:29:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qKkx3-0006ze-AX; Sat, 15 Jul 2023 15:29:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKkwx-0006zQ-UF for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 15:29:04 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qKkww-00067b-CO for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 15:29:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qKkww-0001Pe-8Z for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 15:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Jul 2023 19:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64596 X-GNU-PR-Package: emacs Original-Received: via spool by 64596-submit@debbugs.gnu.org id=B64596.16894493045384 (code B ref 64596); Sat, 15 Jul 2023 19:29:02 +0000 Original-Received: (at 64596) by debbugs.gnu.org; 15 Jul 2023 19:28:24 +0000 Original-Received: from localhost ([127.0.0.1]:46118 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKkwK-0001Om-Bf for submit@debbugs.gnu.org; Sat, 15 Jul 2023 15:28:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44754) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKkwI-0001OZ-Kt for 64596@debbugs.gnu.org; Sat, 15 Jul 2023 15:28:23 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKkwD-00056y-Ao; Sat, 15 Jul 2023 15:28:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=8Nhr0hTD8QreDN5PAa9lS65D6nZ1ZKcNewZ3d88NIOU=; b=Y/mUu1K5IEPS nIGGpEjP64bCiPKEGcP0MxqbClwgl0iR/5gKlBDHn/JVJcAkZVfGrcD+8taqHiKpNk5EJ+0JLsfIT Cz608R696CY1W7frbVTP5r0RrNfghOBwI2tjUmv5+KlaCMIZKjakp6ksMBlTP6uw5d6vpXYD+TwOb HZqLrcjB9n18O5DW3iD5k7L+HXuiRTtGSPsf+f93tB5aH2T73QZC0q4rXUNZ32+6Nvp8n7Cd1riGx /EAPuIuH3oKrko0mKT5GwAtWf/4Q+Ed80WyKD5gyBs01eRN+dzH3AfWyFGCetK3+CCdDyA82GQL5q qTjdqPi93L4U+zsWpVSJJA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKkwC-0005Uz-Op; Sat, 15 Jul 2023 15:28:17 -0400 In-Reply-To: (message from Stefan Monnier on Sat, 15 Jul 2023 14:15:41 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265242 Archived-At: > From: Stefan Monnier > Cc: yantar92@posteo.net, 64596@debbugs.gnu.org > Date: Sat, 15 Jul 2023 14:15:41 -0400 > > > Or why redisplay_internal does this: > > > > consider_all_windows_p = (update_mode_lines > > || windows_or_buffers_changed); > > Sorry, I skipped this part in my previous email. > I understand the above code, but I'm not sure what explanation might > be needed so you can understand it as well. Maybe the problem is the > name `consider_all_windows_p` which suggests that all windows will be > updated, but it only says that we should loop through all the windows to > try and find those which need to be updated. The actual issue with the above is different: it implies that update_mode_lines _always_ indicates that more than a single mode line should be updated (which is why we need to "consider all windows"). But is that actually true, i.e. does every place that assigns non-zero to update_mode_lines indeed perform a change which makes it _necessary_ to consider non-selected windows?