From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65156: 29.1; Reading from pipe with --insert or insert-file-contents no longer supported Date: Wed, 09 Aug 2023 14:31:35 +0300 Message-ID: <83a5v0moyw.fsf@gnu.org> References: <4b873c29-e8ca-403c-bd37-a531d93661f3@lucaswerkmeister.de> <83fs4tmlik.fsf@gnu.org> <83cyzxmj1g.fsf@gnu.org> <87o7jhx776.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35563"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, eggert@cs.ucla.edu, 65156@debbugs.gnu.org, mail@lucaswerkmeister.de To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 09 13:32:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qThQD-0008yf-1V for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Aug 2023 13:32:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qThQ3-0003Xn-Gs; Wed, 09 Aug 2023 07:32:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qThQ2-0003XU-S1 for bug-gnu-emacs@gnu.org; Wed, 09 Aug 2023 07:32:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qThQ2-0004S8-J8 for bug-gnu-emacs@gnu.org; Wed, 09 Aug 2023 07:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qThQ2-0001iG-F6 for bug-gnu-emacs@gnu.org; Wed, 09 Aug 2023 07:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Aug 2023 11:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65156 X-GNU-PR-Package: emacs Original-Received: via spool by 65156-submit@debbugs.gnu.org id=B65156.16915806846540 (code B ref 65156); Wed, 09 Aug 2023 11:32:02 +0000 Original-Received: (at 65156) by debbugs.gnu.org; 9 Aug 2023 11:31:24 +0000 Original-Received: from localhost ([127.0.0.1]:38383 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qThPP-0001hP-LJ for submit@debbugs.gnu.org; Wed, 09 Aug 2023 07:31:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41314) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qThPN-0001hC-GN for 65156@debbugs.gnu.org; Wed, 09 Aug 2023 07:31:22 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qThPD-0004Es-TC; Wed, 09 Aug 2023 07:31:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=n2eI6D30nmv7XPrudonhXfblFH97fKHzvopTdGCbF4A=; b=kdzao6RMQcBr 6RV2t32K9D2cXZwBCOLuMCwIzH0MsFgi/jbzyW8Kwah0SR8C2pv4oZ8sSAPvk6e6+SsCFUseDnoKS GzcIYDwxzMzwEnEKnlv64/34Q7vHwcJ/a8O5eLb+NECIftzPLUmTxdiO2XShqQ1PL70Y8flPf7ZUP w80j4agx3Y6zQvX1ghEWJV0qPS4kBx65UdOS3NXE0+rbahFF38TteD0DWrwa7A6zS2q2LeohpekeW sviZ9rfv2lb02FO378sSwN10wIps/VUJg44WEEYZ/eMPkcAudXSmyY/Dvgm5+XRLeGqdD2J3fBW9v VfGZKxzEiUdysJ9gJkVVdw==; In-Reply-To: <87o7jhx776.fsf@yahoo.com> (message from Po Lu on Wed, 09 Aug 2023 10:47:41 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267018 Archived-At: > From: Po Lu > Cc: mail@lucaswerkmeister.de, eggert@cs.ucla.edu, larsi@gnus.org, > 65156@debbugs.gnu.org > Date: Wed, 09 Aug 2023 10:47:41 +0800 > > The change presently in place on emacs-29 should be replaced with a > one-line change that replaces: > > seekable = lseek (fd, 0, SEEK_CUR) < 0; > > with > > seekable = lseek (fd, 0, SEEK_CUR) != (off_t) -1; Thanks. In the future, when you encounter such bugs, please look into their VCS history, and if the bug was introduced during the development of the last release, fix it on the release branch, especially if the fix is simple and safe.