From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: larsi@gnus.org, 65156@debbugs.gnu.org, mail@lucaswerkmeister.de
Subject: bug#65156: 29.1; Reading from pipe with --insert or insert-file-contents no longer supported
Date: Thu, 10 Aug 2023 11:15:28 +0300 [thread overview]
Message-ID: <83a5uzjotb.fsf@gnu.org> (raw)
In-Reply-To: <6755e91e-1318-8ca8-33e4-30d354d95a2f@cs.ucla.edu> (message from Paul Eggert on Wed, 9 Aug 2023 23:08:49 -0700)
> Date: Wed, 9 Aug 2023 23:08:49 -0700
> Cc: mail@lucaswerkmeister.de, larsi@gnus.org, 65156@debbugs.gnu.org
> From: Paul Eggert <eggert@cs.ucla.edu>
>
> On 2023-08-09 22:17, Eli Zaretskii wrote:
> > If REPLACE is the symbol ‘if-regular’, then eschew preserving marker
> > positions or the undo list if REPLACE is nil if FILENAME is not a
> > regular file. Otherwise, signal an error if REPLACE is non-nil and
> > FILENAME is not a regular file.
> >
> > Which part(s) of this are unclear?
>
> In "If REPLACE is the symbol 'if-regular', then <X> if REPLACE is nil if
> <Y>. Otherwise, ..." I don't know what the first sentence means.
I think it should be changed to say this instead:
If REPLACE is the symbol ‘if-regular’, then eschew preserving marker
positions or the undo list when FILENAME is not a regular file.
Otherwise, signal an error if REPLACE is non-nil and FILENAME is not
a regular file.
AFAICT, this is what the code does.
> Nor do I know which "if" the "Otherwise" is referring to.
It alludes to the case that REPLACE is not 'if-regular'.
> Nor is it easy to see how this paragraph connects to the previous one,
> the one that begins "If optional fifth argument REPLACE is non-nil" and
> that goes on to say "When REPLACE is non-nil" as if the second phrase
> were not redundant (so which part of that paragraph talks about what
> happens when REPLACE being nil?).
This describes what happens when REPLACE is neither nil nor
'if-regular', AFAICT. IOW, the "smart" replacement happens only with
regular files; with non-regular files we either erase the buffer and
insert the stuff from the file (if REPLACE is 'if-regular') or signal
an error.
If you agree that this is what the doc string should say, I will
reword it (but feel free to beat me to that ;-).
next prev parent reply other threads:[~2023-08-10 8:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 18:20 bug#65156: 29.1; Reading from pipe with --insert or insert-file-contents no longer supported Lucas Werkmeister
2023-08-08 18:33 ` Eli Zaretskii
2023-08-08 19:27 ` Eli Zaretskii
2023-08-09 2:47 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-09 11:31 ` Eli Zaretskii
2023-08-09 20:57 ` Paul Eggert
2023-08-10 5:17 ` Eli Zaretskii
2023-08-10 6:08 ` Paul Eggert
2023-08-10 8:15 ` Eli Zaretskii [this message]
2023-08-11 17:18 ` Paul Eggert
2023-08-11 18:30 ` Eli Zaretskii
2023-08-11 21:45 ` Paul Eggert
2023-08-12 8:05 ` Eli Zaretskii
2023-08-12 8:58 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-09 8:07 ` Mattias Engdegård
2023-08-09 8:15 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-09 8:29 ` Mattias Engdegård
2023-08-09 12:00 ` Eli Zaretskii
2023-08-09 12:03 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a5uzjotb.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=65156@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=larsi@gnus.org \
--cc=mail@lucaswerkmeister.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.