From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66431: [PATCH] Fix reset treesit--explorer-last-node when explorer buffer was killed Date: Sat, 14 Oct 2023 11:17:42 +0300 Message-ID: <83a5slsjmh.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21034"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 66431@debbugs.gnu.org To: nvp , Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 14 10:18:58 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qrZrO-0005BJ-8J for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Oct 2023 10:18:58 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qrZr6-0003oY-LF; Sat, 14 Oct 2023 04:18:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qrZr5-0003o7-4m for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2023 04:18:39 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qrZr4-0003Ly-7N for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2023 04:18:38 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qrZrR-0006jZ-Lw for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2023 04:19:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Oct 2023 08:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66431 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66431-submit@debbugs.gnu.org id=B66431.169727149325825 (code B ref 66431); Sat, 14 Oct 2023 08:19:01 +0000 Original-Received: (at 66431) by debbugs.gnu.org; 14 Oct 2023 08:18:13 +0000 Original-Received: from localhost ([127.0.0.1]:47829 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrZqf-0006iS-I3 for submit@debbugs.gnu.org; Sat, 14 Oct 2023 04:18:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38232) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrZqd-0006iD-On for 66431@debbugs.gnu.org; Sat, 14 Oct 2023 04:18:12 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qrZqA-0003I1-UQ; Sat, 14 Oct 2023 04:17:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=kJ9ec5YVbplTugcU+c5PM9EXZa7U37Rz6Ni7FfXQtSI=; b=q+EIhPKYD9Nu cbbbobWKX5qYA4a9bxa2EVVkZ9idLuCZ4clZS0ltQC+n2UD8+UUEQbQMthK/+AwuT3uAZ3wEnVLEF eUXkuvsngEdeEK2h66I5+xEP6N1Hj1bgTm7hf7dtEoOPxnR/xr/3qeurtv4g+YLxuSbHkD7Ytf8UZ zCydtuztiqPbbWGepKHsTTPPU/ZubOwMhE+7UYFARwo8J3a/iqEGQUIB9Y+I9kjMeh0g67kur4Kbm ML7KP4AbYC8Yhwz0c5SLQA5SQ1K5DqStzJHOLGSMuHPrL8I16+P0QQN6ddmSJ7CwdykmTCeVHd4Qo 5tp5D1Y6j6tstBH9hmuhyg==; In-Reply-To: (message from nvp on Mon, 9 Oct 2023 23:02:48 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272391 Archived-At: > From: nvp > Date: Mon, 9 Oct 2023 23:02:48 -0700 > > Tags: patch > > Bug: After `treesit-explorer-mode` is enabled in a buffer and its > associated `treesit--explorer-buffer` is killed, a subsequent call > to `treesit-explorer-mode` initially displays an empty explorer > buffer b/c `treesit--explorer-refresh` sees old value for > `treesit--explorer-last-node`. > > * lisp/treesit.el (treesit-explorer-mode): reset > `treesit--explorer-last-node` when `treesit--explorer-buffer` was killed > > In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version > 3.24.33, cairo version 1.16.0) of 2023-10-05 built on noah-X580VD > Repository revision: 505c80623049d9e181918acdac8229c9a2041b1e > Repository branch: master > Windowing system distributor 'The X.Org Foundation', version 11.0.12101004 > System Description: Ubuntu 22.04.3 LTS Yuan, could you please look into this? Is the patch OK to go in, and if so, should it be installed on emacs-29?