From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67053: 29.1; Doc string of variable `dired-use-ls-dired' Date: Sat, 11 Nov 2023 08:49:18 +0200 Message-ID: <83a5rkyec1.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7335"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67053@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 11 07:50:32 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r1hpA-0001jG-GB for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 11 Nov 2023 07:50:32 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r1hp1-0006Sk-VX; Sat, 11 Nov 2023 01:50:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r1hp0-0006Sb-Jj for bug-gnu-emacs@gnu.org; Sat, 11 Nov 2023 01:50:22 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r1hp0-0004lB-AX for bug-gnu-emacs@gnu.org; Sat, 11 Nov 2023 01:50:22 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r1hpe-0006pD-2X for bug-gnu-emacs@gnu.org; Sat, 11 Nov 2023 01:51:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Nov 2023 06:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67053 X-GNU-PR-Package: emacs Original-Received: via spool by 67053-submit@debbugs.gnu.org id=B67053.169968541526152 (code B ref 67053); Sat, 11 Nov 2023 06:51:02 +0000 Original-Received: (at 67053) by debbugs.gnu.org; 11 Nov 2023 06:50:15 +0000 Original-Received: from localhost ([127.0.0.1]:51379 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r1hos-0006nk-Jt for submit@debbugs.gnu.org; Sat, 11 Nov 2023 01:50:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51964) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r1hon-0006nN-BJ for 67053@debbugs.gnu.org; Sat, 11 Nov 2023 01:50:12 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r1ho2-0003wi-Ji; Sat, 11 Nov 2023 01:49:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=5Wp/tDWbDY3Jofe71GR1ygpgq9oUcJRRjNp9QdMIHIU=; b=XEmU8RzXTro/ 1h7PW7FK/T2cM5Izx0h+IRkHsKQuvL9t3KGArON7hiDtoQdvN3+DgR5DnxsNnV4JTQZqk7obH7q5W Tqz+ZBn0JqA+yVR52ShaD7tQ8QpQ7IfqdbinEJp+Q2DoZJc/Tof5Y4ScVrC7hao69AnN7yb3eLby3 yayP0hO7GuTSbAmOPHS8ktaIUcpjg84NGL+he8/2o1K/5tj+adHmQvjx/xyjv96MJ+xBR3iBLO3zD ohGCVg22X6rD2epUE35dZrXTDMwDzPRGyl7ZYbtjsBJqXCAsHYq9euacxQEuSD1unnqOlk+y/zhjQ 1aNYiu+tJdjgd25m8HrHCg==; In-Reply-To: (message from Drew Adams on Fri, 10 Nov 2023 20:41:01 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274136 Archived-At: > From: Drew Adams > Date: Fri, 10 Nov 2023 20:41:01 +0000 > > emacs -Q. > > With MS Windows, which uses ls-lisp, the value of this variable is > `unspecified'. I think it always has this value. Maybe this is > necessary/correct (?). > > But the doc string says this: > > The special value of 'unspecified' means to check whether "ls" > supports the "--dired" option, and save the result in this > variable. This is performed the first time 'dired-insert-directory' > is invoked. > > That's not as clear as it should be. It gives the impression that the > result of saving the result of that check of the value will be nil or > some non-nil value other than `unspecified'. Which is exactly what happens, when Dired uses 'ls'. > It would be better to at least say that the result of the check can be > that it hasn't been determined whether "ls" supports the "--dired" > option, and thus that the variable value will remain `unspecified' > after the check. No, it will be either nil or non-nil, depending on the results of the test. Which is exactly what the doc string says. > Or if it's the case that the check does, for MS Windows (or more > generally for ls-lisp use), determine that "ls" doesn't support > "--dired", then the value should be changed from `unspecified' to some > other non-nil value, such as `t'. No, it changes to nil if 'ls' that is used by Dired doesn't support '--dired'. As expected. > Perhaps I'm misunderstanding something? If so, please make the doc > string clearer to avoid such misunderstanding. Thx. I don't see what is unclear in the doc string. I suggest that you try it: emacs -Q M-x set-variable RET ls-lisp-use-insert-directory-program RET t RET C-h v dired-use-ls-dired RET C-x d SOME-DIRECTORY RET C-h v dired-use-ls-dired RET Depending on what version of 'ls' you have installed, the 2nd "C-h v" will show either t or nil as the value of the variable. So I don't see anything that we need to fix in this doc string.