From: Eli Zaretskii <eliz@gnu.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: 67053@debbugs.gnu.org
Subject: bug#67053: 29.1; Doc string of variable `dired-use-ls-dired'
Date: Sat, 11 Nov 2023 08:49:18 +0200 [thread overview]
Message-ID: <83a5rkyec1.fsf@gnu.org> (raw)
In-Reply-To: <SJ0PR10MB5488492A7654F597AF02A69FF3AEA@SJ0PR10MB5488.namprd10.prod.outlook.com> (message from Drew Adams on Fri, 10 Nov 2023 20:41:01 +0000)
> From: Drew Adams <drew.adams@oracle.com>
> Date: Fri, 10 Nov 2023 20:41:01 +0000
>
> emacs -Q.
>
> With MS Windows, which uses ls-lisp, the value of this variable is
> `unspecified'. I think it always has this value. Maybe this is
> necessary/correct (?).
>
> But the doc string says this:
>
> The special value of 'unspecified' means to check whether "ls"
> supports the "--dired" option, and save the result in this
> variable. This is performed the first time 'dired-insert-directory'
> is invoked.
>
> That's not as clear as it should be. It gives the impression that the
> result of saving the result of that check of the value will be nil or
> some non-nil value other than `unspecified'.
Which is exactly what happens, when Dired uses 'ls'.
> It would be better to at least say that the result of the check can be
> that it hasn't been determined whether "ls" supports the "--dired"
> option, and thus that the variable value will remain `unspecified'
> after the check.
No, it will be either nil or non-nil, depending on the results of the
test. Which is exactly what the doc string says.
> Or if it's the case that the check does, for MS Windows (or more
> generally for ls-lisp use), determine that "ls" doesn't support
> "--dired", then the value should be changed from `unspecified' to some
> other non-nil value, such as `t'.
No, it changes to nil if 'ls' that is used by Dired doesn't support
'--dired'. As expected.
> Perhaps I'm misunderstanding something? If so, please make the doc
> string clearer to avoid such misunderstanding. Thx.
I don't see what is unclear in the doc string. I suggest that you
try it:
emacs -Q
M-x set-variable RET ls-lisp-use-insert-directory-program RET t RET
C-h v dired-use-ls-dired RET
C-x d SOME-DIRECTORY RET
C-h v dired-use-ls-dired RET
Depending on what version of 'ls' you have installed, the 2nd "C-h v"
will show either t or nil as the value of the variable.
So I don't see anything that we need to fix in this doc string.
prev parent reply other threads:[~2023-11-11 6:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 20:41 bug#67053: 29.1; Doc string of variable `dired-use-ls-dired' Drew Adams
2023-11-10 21:38 ` Jeremy Bryant via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-10 23:40 ` Drew Adams
2023-11-11 7:14 ` Eli Zaretskii
2023-11-11 4:48 ` Michael Heerdegen
2023-11-11 5:53 ` Drew Adams
2023-11-11 6:43 ` Michael Heerdegen
2023-11-11 8:04 ` Eli Zaretskii
2023-11-11 6:49 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a5rkyec1.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=67053@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.