From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67615: [PATCH v5] * lisp/info.el (Info-url-alist): New option mapping manuals to URLs. Date: Sat, 13 Jan 2024 11:51:35 +0200 Message-ID: <83a5p9h87s.fsf@gnu.org> References: <87plzmsuge.fsf@posteo.de> <87leaast8s.fsf@posteo.de> <87sf4ii8oi.fsf@posteo.de> <87o7f6hsfj.fsf@posteo.de> <87y1e5tumu.fsf@posteo.de> <83fs0byanf.fsf@gnu.org> <87y1e3ei0t.fsf@posteo.de> <878r5pzsxy.fsf@posteo.de> <83bkahdyjy.fsf@gnu.org> <87sf37v5fi.fsf@posteo.de> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12758"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67615@debbugs.gnu.org To: Mekeor Melire Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 13 10:53:39 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rOahu-00038V-8z for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Jan 2024 10:53:38 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rOahN-0004xR-Mz; Sat, 13 Jan 2024 04:53:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rOahM-0004xC-7C for bug-gnu-emacs@gnu.org; Sat, 13 Jan 2024 04:53:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rOahL-0006ST-VZ for bug-gnu-emacs@gnu.org; Sat, 13 Jan 2024 04:53:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rOahK-0002we-DX for bug-gnu-emacs@gnu.org; Sat, 13 Jan 2024 04:53:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Jan 2024 09:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67615 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67615-submit@debbugs.gnu.org id=B67615.170513954811265 (code B ref 67615); Sat, 13 Jan 2024 09:53:02 +0000 Original-Received: (at 67615) by debbugs.gnu.org; 13 Jan 2024 09:52:28 +0000 Original-Received: from localhost ([127.0.0.1]:38485 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOagl-0002vc-ST for submit@debbugs.gnu.org; Sat, 13 Jan 2024 04:52:28 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43124) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOagj-0002vQ-Ov for 67615@debbugs.gnu.org; Sat, 13 Jan 2024 04:52:26 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rOagd-00065I-OO; Sat, 13 Jan 2024 04:52:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=BTaS/F3PE3xXd/AEqHF1/wdr1ElA9ED9p/LUyj/QM0Q=; b=lWMbk4Euoh/k sXvSDulqX7xPtZeb/bU2hRxYJRhTKYu58ybv4ycPTA7QsCg9MjEagoASm7iQWFLRxI0+w/B6zB64i pA9rfnL7d2tJzidMaiTXjvFqBGL1il+rYQb2rZmb66Gg0yz0XYYB3fizl3oDQCAjVI1v3KRCWVUdB j+MrDUgFPVYoryLRAB4umXyeMNGLeAtTMggmpTOzIWBihOf04Z3H+q6LI+2jRUxamXl7F+CCcwkha PvH16Ve+g/EAj3+Mm80dILl+ecDi2i9n86Fheaza9dr8QF9Rw04NqG6yvBwnTyjeUbpAzJEt2SVub Vh8I5qJTSUZMR8IvKfXidQ==; In-Reply-To: <87sf37v5fi.fsf@posteo.de> (message from Mekeor Melire on Mon, 08 Jan 2024 21:56:03 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278115 Archived-At: > From: Mekeor Melire > Cc: 67615@debbugs.gnu.org > Date: Mon, 08 Jan 2024 21:56:03 +0000 > > > It wasn't forgotten, but thanks anyway. > > > I have a few minor comments to this version > > Thanks for... > > - not forgetting, > - for all the patience, and > - the comments. > > Attached is a new version of the patch which includes the requested > improvements: > > - In a docstring, do not break line within form specification. > - Pass a previously missing argument to `error'. > - Use `seq-contains-p' instead of `seq-contains'. Thanks. I was going to install this, but it causes info-tests in the test suite to fail: Test test-info-urls backtrace: signal(ert-test-failed (((should (equal (Info-url-for-node "(emacs)M ert-fail(((should (equal (Info-url-for-node "(emacs)Minibuffer") "ht (if (unwind-protect (setq value-2 (apply fn-0 args-1)) (setq form-de (let (form-description-4) (if (unwind-protect (setq value-2 (apply f (let ((value-2 'ert-form-evaluation-aborted-3)) (let (form-descripti (let* ((fn-0 #'equal) (args-1 (condition-case err (list (Info-url-fo (closure (t) nil (let* ((fn-0 #'equal) (args-1 (condition-case err ( #f(compiled-function () #)() handler-bind-1(#f(compiled-function () # Subject: [PATCH] * lisp/info.el (Info-url-alist): New option mapping manuals > to URLs. Please also improve the commit log message to mention all the changes, not just the new option. See CONTRIBUTE for details, and you can use "git log" to see many examples of how we do that.