Re: master 84e4bc6219a 1/2: Add input methods for Urdu, Pashto and Sindhi (bug#66470)

[Eli Zaretskii <eliz@gnu.org>]

> From: Michael Albinus <michael.albinus@gmx.de>
> Cc: Rahguzar <rahguzar@zohomail.eu>
> Date: Fri, 19 Jan 2024 09:45:36 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > branch: master
> > commit 84e4bc6219af2c08097027d4b75043b23c1fcce6
> > Author: Rahguzar <rahguzar@zohomail.eu>
> > Commit: Eli Zaretskii <eliz@gnu.org>
> >
> >     Add input methods for Urdu, Pashto and Sindhi (bug#66470)
> 
> This commit has added the following error in Emacs' tests:
> 
> --8<---------------cut here---------------start------------->8---
> # make -C test test-custom-deps
> The following load problems appeared:
> (pakistan-urdu-input pakistan (file-missing Cannot open load file No such file or directory pakistan))
> (quail pakistan (file-missing Cannot open load file No such file or directory pakistan))
> Test test-custom-deps backtrace:
>   signal(ert-test-failed (((should-not cus-test-deps-errors) :form cus
>   ert-fail(((should-not cus-test-deps-errors) :form cus-test-deps-erro
>   (if (not (unwind-protect (setq value-5 cus-test-deps-errors) (setq f
>   (let (form-description-6) (if (not (unwind-protect (setq value-5 cus
>   (let ((value-5 (gensym "ert-form-evaluation-aborted-"))) (let (form-
>   (closure (cus-test-deps-errors t) nil (let* ((fn-0 #'file-readable-p
>   ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
>   ert-run-test(#s(ert-test :name test-custom-deps :documentation nil :
>   ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
>   ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil
>   ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp))))
>   ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco
>   eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n
>   command-line-1(("-L" ":." "-l" "ert" "-l" "misc/test-custom-deps.el"
>   command-line()
>   normal-top-level()
> Test test-custom-deps condition:
>     (ert-test-failed
>      ((should-not cus-test-deps-errors) :form cus-test-deps-errors :value
>       ((pakistan-urdu-input pakistan
> 			    (file-missing "Cannot open load file"
> 					  "No such file or directory"
> 					  "pakistan"))
>        (quail pakistan
> 	      (file-missing "Cannot open load file"
> 			    "No such file or directory" "pakistan")))))
>    FAILED  1/1  test-custom-deps (40.411856 sec) at misc/test-custom-deps.el:35
> 
> Ran 1 tests, 0 results as expected, 1 unexpected (2024-01-18 21:00:25+0100, 41.295278 sec)
> 
> 1 unexpected results:
>    FAILED  test-custom-deps
> --8<---------------cut here---------------end--------------->8---

I tried to look into this.  It seems test-custom-deps runs
cus-test-deps and then requires that cus-test-deps-errors is nil.  I
therefore ran cus-test-deps interactively, and looked at
cus-test-deps-errors.  It is not nil, but its value is

  ((org-babel ob-vala (file-missing "Cannot open load file" "No such file or directory" "ob-vala")) (org-babel ob-stan (file-missing "Cannot open load file" "No such file or directory" "ob-stan")) (org-babel ob-picolisp (file-missing "Cannot open load file" "No such file or directory" "ob-picolisp")) (org-babel ob-J (file-missing "Cannot open load file" "No such file or directory" "ob-J")))

which doesn't mention pakistan at all.

So I'm unsure how to proceed.  It would be useful to see the value of
cus-test-deps-errors in the test that fails, or maybe I'm missing
something in how this test should be run interactively.

P.S. My guess is that some autoload is missing from pakistan.el, but
without reproducing the problem I cannot verify that and cannot test a
solution, and the error message from the failing test is not helpful,
as it doesn't divulge the important details.