From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#7225: 23.2.50; [PATCH] C-c C-c doesn't work in shell mode (Cygwin) Date: Sat, 16 Oct 2010 15:26:44 +0200 Message-ID: <838w1yb757.fsf@gnu.org> References: <4CB8E584.1090800@cornell.edu> <83iq12bnjj.fsf@gnu.org> <4CB99E2C.5030904@cornell.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1287236567 23769 80.91.229.12 (16 Oct 2010 13:42:47 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 16 Oct 2010 13:42:47 +0000 (UTC) Cc: 7225@debbugs.gnu.org To: Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 16 15:42:46 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1P7722-0003pi-SO for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Oct 2010 15:42:43 +0200 Original-Received: from localhost ([127.0.0.1]:52820 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P7722-0003U9-Bu for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Oct 2010 09:42:42 -0400 Original-Received: from [140.186.70.92] (port=58541 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P771s-0003SD-AR for bug-gnu-emacs@gnu.org; Sat, 16 Oct 2010 09:42:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P771k-0003xV-Ib for bug-gnu-emacs@gnu.org; Sat, 16 Oct 2010 09:42:32 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:60043) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P771k-0003xK-Eu for bug-gnu-emacs@gnu.org; Sat, 16 Oct 2010 09:42:24 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1P76jx-0008NB-T8; Sat, 16 Oct 2010 09:24:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Oct 2010 13:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 7225-submit@debbugs.gnu.org id=B7225.128723539432177 (code B ref 7225); Sat, 16 Oct 2010 13:24:01 +0000 Original-Received: (at 7225) by debbugs.gnu.org; 16 Oct 2010 13:23:14 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P76jC-0008Mw-3M for submit@debbugs.gnu.org; Sat, 16 Oct 2010 09:23:14 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P76jA-0008Mr-4F for 7225@debbugs.gnu.org; Sat, 16 Oct 2010 09:23:13 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LAD00J00X5VI600@a-mtaout20.012.net.il> for 7225@debbugs.gnu.org; Sat, 16 Oct 2010 15:26:43 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.229.93.189]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LAD00JTTXCI0970@a-mtaout20.012.net.il>; Sat, 16 Oct 2010 15:26:43 +0200 (IST) In-reply-to: <4CB99E2C.5030904@cornell.edu> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sat, 16 Oct 2010 09:24:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:40923 Archived-At: > Date: Sat, 16 Oct 2010 08:44:28 -0400 > From: Ken Brown > CC: "7225@debbugs.gnu.org" <7225@debbugs.gnu.org> > > >> C-c C-c > >> (The cat process doesn't get killed.) > > > > Is the reason for this known? It looks like the `kill' syscall isn't > > doing its job, but if that's so, there should be a good reason for > > that. > > The problem is the group id in the call to 'kill'. Cygwin doesn't > define TIOCGPGRP, and the group id as set in line 6233 of process.c > (emacs-23 branch) is the wrong group id. Does Cygwin have another way of getting the process group ID? If so, can it be used in process_send_signal instead of emacs_get_tty_pgrp? > > Did you test it with a subprogram that puts its stdin into a mode > > where (speaking in termios terms) the ISIG flag in c_lflag passed to > > tcsetattr is unset? > > I don't know how to do this. Can you give me a short test program to try? Sorry, no, not off-hand. > > In any case, I wouldn't recommend to take this workaround unless we > > understand why this doesn't work without it. > > I'm not sure why you call it a workaround. The comments preceding (and > in) the definition of process_send_signal make it clear that > SIGNALS_VIA_CHARACTERS is the preferred method. It's used by GNU/Linux > (see src/s/gnu-linux.h) and several other systems. SIGNALS_VIA_CHARACTERS is the preferred method for a few signals that are raised by keyboard characters. But unless you find a way to send any signal to a subprocess on Cygwin, you will still have a bug, although not with SIGINT. So I suggest to look into tweaking process_send_signal so that it works with Cygwin. It looks like it makes all kinds of assumptions regarding systems that don't have TIOCGPGRP, and they are probably wrong for Cyugwin. Or maybe you need something special in EMACS_KILLPG. When you have fixed process_send_signal, you can then introduce SIGNALS_VIA_CHARACTERS for Cygwin. However, this is just a suggestion. If you don't feel like digging into these issues, go ahead and commit the change.