From: Eli Zaretskii <eliz@gnu.org>
To: emacs-devel@gnu.org
Subject: mail-add-attachment
Date: Sat, 03 Sep 2011 13:05:21 +0300 [thread overview]
Message-ID: <838vq60wm6.fsf@gnu.org> (raw)
Is it okay to install this command at this time? I know we're in a
feature freeze, but the new command is actually a very thin wrapper
around code we already use elsewhere (gnus-dired.el and mml.el). The
result will be that users of sendmail.el will be able to send MIME
attachments. Here's the patch:
=== modified file 'lisp/mail/sendmail.el'
--- lisp/mail/sendmail.el 2011-09-03 10:00:13 +0000
+++ lisp/mail/sendmail.el 2011-09-03 10:00:32 +0000
@@ -34,6 +34,21 @@
(autoload 'mml-to-mime "mml"
"Translate the current buffer from MML to MIME.")
+(autoload 'mml-attach-file "mml"
+ "Attach a file to the outgoing MIME message.
+The file is not inserted or encoded until you send the message with
+`\\[message-send-and-exit]' or `\\[message-send]'.
+
+FILE is the name of the file to attach. TYPE is its
+content-type, a string of the form \"type/subtype\". DESCRIPTION
+is a one-line description of the attachment. The DISPOSITION
+specifies how the attachment is intended to be displayed. It can
+be either \"inline\" (displayed automatically within the message
+body) or \"attachment\" (separate from the body).")
+
+(autoload 'mm-default-file-encoding "mm-encode"
+ "Return the default encoding for FILE.")
+
(defgroup sendmail nil
"Mail sending commands for Emacs."
:prefix "mail-"
@@ -355,6 +370,9 @@ The default value matches citations like
(define-key map [menu-bar mail]
(cons "Mail" (make-sparse-keymap "Mail")))
+ (define-key map [menu-bar mail attachment]
+ '("Attach File" . mail-add-attachment))
+
(define-key map [menu-bar mail fill]
'("Fill Citation" . mail-fill-yanked-message))
@@ -700,6 +718,8 @@ Here are commands that move to a header
\\[mail-signature] mail-signature (insert `mail-signature-file' file).
\\[mail-yank-original] mail-yank-original (insert current message, in Rmail).
\\[mail-fill-yanked-message] mail-fill-yanked-message (fill what was yanked).
+\\[mail-attach-file] insert a text file into the message.
+\\[mail-add-attachment] add to the message a file as a MIME attachment.
Turning on Mail mode runs the normal hooks `text-mode-hook' and
`mail-mode-hook' (in that order)."
(make-local-variable 'mail-reply-action)
@@ -1716,6 +1736,15 @@ If the current line has `mail-yank-prefi
(insert-file-contents file)
(or (bolp) (newline))
(goto-char start))))
+
+(defun mail-add-attachment (file)
+ "Add a file as a MIME attachment to the end of the message."
+ (interactive "fAttach file: ")
+ (mml-attach-file file
+ (or (mm-default-file-encoding file)
+ "application/octet-stream") nil)
+ (setq mail-encode-mml t))
+
\f
;; Put these commands last, to reduce chance of lossage from quitting
;; in middle of loading the file.
next reply other threads:[~2011-09-03 10:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-03 10:05 Eli Zaretskii [this message]
2011-09-03 10:33 ` mail-add-attachment Andreas Schwab
2011-09-03 11:38 ` mail-add-attachment Eli Zaretskii
2011-09-03 11:54 ` mail-add-attachment Eli Zaretskii
2011-09-03 18:36 ` mail-add-attachment Chong Yidong
2011-09-08 16:38 ` mail-add-attachment Eli Zaretskii
2011-09-09 14:32 ` mail-add-attachment Stefan Monnier
2011-09-09 15:04 ` mail-add-attachment Eli Zaretskii
2011-09-09 16:15 ` mail-add-attachment Lars Magne Ingebrigtsen
2011-09-09 21:49 ` mail-add-attachment Stefan Monnier
2011-09-10 0:02 ` mail-add-attachment Lars Magne Ingebrigtsen
2011-09-10 1:40 ` mail-add-attachment Stefan Monnier
2011-09-10 8:32 ` mail-add-attachment Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=838vq60wm6.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.