From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#10164: 24.0.91; Instant crash enabling linum-mode Date: Wed, 30 Nov 2011 18:56:31 +0200 Message-ID: <838vmx5z28.fsf@gnu.org> References: <4ED58F60.4000604@code-affinity.com> <83bort60k0.fsf@gnu.org> <8762i13766.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1322672291 9870 80.91.229.12 (30 Nov 2011 16:58:11 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 30 Nov 2011 16:58:11 +0000 (UTC) Cc: lekktu@gmail.com, 10164-done@debbugs.gnu.org, tim.crews@code-affinity.com To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 30 17:58:05 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RVnTw-0003FD-5H for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Nov 2011 17:58:04 +0100 Original-Received: from localhost ([::1]:60219 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RVnTv-0008Gu-Qc for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Nov 2011 11:58:03 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:48420) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RVnTt-0008Fz-94 for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2011 11:58:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RVnTr-0006IL-6W for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2011 11:58:01 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46092) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RVnTr-0006IB-13 for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2011 11:57:59 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RVnTu-0004Lw-HM for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2011 11:58:02 -0500 Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Nov 2011 16:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 10164 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 10164@debbugs.gnu.org, eliz@gnu.org Original-Received: via spool by 10164-done@debbugs.gnu.org id=D10164.132267227016711 (code D ref 10164); Wed, 30 Nov 2011 16:58:02 +0000 Original-Received: (at 10164-done) by debbugs.gnu.org; 30 Nov 2011 16:57:50 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RVnTh-0004LU-N8 for submit@debbugs.gnu.org; Wed, 30 Nov 2011 11:57:50 -0500 Original-Received: from mtaout22.012.net.il ([80.179.55.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RVnTc-0004LI-OQ for 10164-done@debbugs.gnu.org; Wed, 30 Nov 2011 11:57:46 -0500 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LVH00300GES6Q00@a-mtaout22.012.net.il> for 10164-done@debbugs.gnu.org; Wed, 30 Nov 2011 18:57:39 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([77.126.234.164]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LVH00257GG2J590@a-mtaout22.012.net.il>; Wed, 30 Nov 2011 18:57:39 +0200 (IST) In-reply-to: <8762i13766.fsf@gnu.org> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 30 Nov 2011 11:58:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:54494 Archived-At: > From: Chong Yidong > Cc: Juanma Barranquero , 10164@debbugs.gnu.org, tim.crews@code-affinity.com > Date: Thu, 01 Dec 2011 00:29:37 +0800 > > > Chong, please hold off the pretest while I debug this. > > I bumped the version number in the trunk before seeing this latest > message. But, I haven't made the pretest tag yet---will wait. Thanks. The bug is fixed in revision 106561. It was simply wrong to try to verify rows' hash values at that spot, because the code immediately before that reallocates the glyph arrays, so the contents of a glyph row could be complete garbage. Therefore, I removed the assertion. I'm amazed that this assertion didn't trigger until now. I guess too few people compile with asserts. Or maybe most calls to adjust_glyph_matrix don't really reallocate, since display margins are a relatively rarely used feature. Sorry about this, it was a shameful thinko on my part to introduce that assertion in the first place.