all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Chong Yidong <cyd@gnu.org>
Cc: lekktu@gmail.com, 10164-done@debbugs.gnu.org,
	tim.crews@code-affinity.com
Subject: bug#10164: 24.0.91; Instant crash enabling linum-mode
Date: Wed, 30 Nov 2011 18:56:31 +0200	[thread overview]
Message-ID: <838vmx5z28.fsf@gnu.org> (raw)
In-Reply-To: <8762i13766.fsf@gnu.org>

> From: Chong Yidong <cyd@gnu.org>
> Cc: Juanma Barranquero <lekktu@gmail.com>,  10164@debbugs.gnu.org,  tim.crews@code-affinity.com
> Date: Thu, 01 Dec 2011 00:29:37 +0800
> 
> > Chong, please hold off the pretest while I debug this.
> 
> I bumped the version number in the trunk before seeing this latest
> message.  But, I haven't made the pretest tag yet---will wait.

Thanks.  The bug is fixed in revision 106561.

It was simply wrong to try to verify rows' hash values at that spot,
because the code immediately before that reallocates the glyph arrays,
so the contents of a glyph row could be complete garbage.  Therefore,
I removed the assertion.

I'm amazed that this assertion didn't trigger until now.  I guess too
few people compile with asserts.  Or maybe most calls to
adjust_glyph_matrix don't really reallocate, since display margins are
a relatively rarely used feature.

Sorry about this, it was a shameful thinko on my part to introduce
that assertion in the first place.





  parent reply	other threads:[~2011-11-30 16:56 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-30  2:05 bug#10164: 24.0.91; Instant crash enabling linum-mode Tim Crews
2011-11-30 12:19 ` Eli Zaretskii
2011-11-30 12:52   ` Dan Nicolaescu
2011-11-30 13:54     ` Eli Zaretskii
2011-11-30 15:51       ` Dan Nicolaescu
2011-11-30 15:01     ` Andy Moreton
2011-11-30 15:10       ` Juanma Barranquero
2011-11-30 12:29 ` Eli Zaretskii
2011-11-30 12:38   ` Juanma Barranquero
2011-11-30 13:40     ` Eli Zaretskii
     [not found]     ` <CAAeL0SS_ydvYGqw0rOd3UR6RoYzJWkEkFhaYX5kZ2m+vTx-Q0w@mail.gmail.com>
     [not found]       ` <E1RVkfB-00062i-AB@fencepost.gnu.org>
     [not found]         ` <CAAeL0SRW1A7-vOzNGxFvGtbv=zVSo2ji+_HB7R8rFtq15ufhPg@mail.gmail.com>
2011-11-30 16:24           ` Eli Zaretskii
2011-11-30 16:29             ` Chong Yidong
2011-11-30 16:35               ` Chong Yidong
2011-11-30 16:39                 ` Juanma Barranquero
2011-11-30 16:42                   ` Chong Yidong
2011-11-30 16:56               ` Eli Zaretskii [this message]
2011-11-30 17:37                 ` Chong Yidong
2011-11-30 18:10                 ` Dan Nicolaescu
2011-11-30 18:29                   ` Eli Zaretskii
2011-11-30 18:55                     ` Dan Nicolaescu
     [not found] ` <handler.10164.D10164.132267227016711.notifdone@debbugs.gnu.org>
2011-11-30 17:29   ` bug#10164: closed (Instant crash enabling linum-mode) Tim Crews
2011-11-30 18:06     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=838vmx5z28.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=10164-done@debbugs.gnu.org \
    --cc=cyd@gnu.org \
    --cc=lekktu@gmail.com \
    --cc=tim.crews@code-affinity.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.