From: Eli Zaretskii <eliz@gnu.org>
To: Erik Charlebois <erikcharlebois@gmail.com>
Cc: 14180-done@debbugs.gnu.org
Subject: bug#14180: PATCH Better fullscreen frame support on Windows
Date: Sat, 20 Apr 2013 10:36:55 +0300 [thread overview]
Message-ID: <838v4d1wmg.fsf@gnu.org> (raw)
In-Reply-To: <CAC+abJbpMHNhrx6zsp=BaEtPknAJNroTo6kUzvwXCLscmry0=w@mail.gmail.com>
> Date: Fri, 19 Apr 2013 20:42:43 -0400
> From: Erik Charlebois <erikcharlebois@gmail.com>
> Cc: 14180@debbugs.gnu.org
>
> The assignment should be on file now.
Indeed, it is. Therefore, I committed your changes as trunk revision
112337.
A few comments on your ChangeLog entries (for the future; I fixed all
of the issues mentioned below):
. We have a separate ChangeLog in src, so the file names should not
include "src/".
. The entries for different files should be separated by an empty
line.
. Each non-empty line should begin with a TAB.
. You forgot to describe the changes in w32term.h.
FYI, here are the log entries I committed in your name:
2013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
* w32fns.c (w32_fullscreen_rect): New function to compute the
window rectangle for the given fullscreen mode.
(w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
longer tunes the window size. This keeps the window's edges flush
with the screen and allows the taskbar to hide itself in fullboth.
* w32term.c (w32fullscreen_hook): 'fullboth' now shows without
window decorations and uses the entire screen.
* w32term.h (w32_fullscreen_rect) Add prototype.
(struct w32_output): Replace normal_width, normal_height,
normal_top, and normal_left members with a single normal_placement
struct.
(FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
Remove macros.
(FRAME_NORMAL_PLACEMENT): New macro.
Thanks again for working on this.
I'm marking this bug as done.
next prev parent reply other threads:[~2013-04-20 7:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-11 4:59 bug#14180: PATCH Better fullscreen frame support on Windows Erik Charlebois
2013-04-12 9:28 ` martin rudalics
2013-04-12 19:32 ` Erik Charlebois
2013-04-13 8:03 ` martin rudalics
2013-04-13 10:09 ` Eli Zaretskii
2013-04-13 11:33 ` Jan Djärv
2013-04-13 11:56 ` Eli Zaretskii
2013-04-14 1:23 ` Erik Charlebois
2013-04-14 6:41 ` Eli Zaretskii
2013-04-20 0:42 ` Erik Charlebois
2013-04-20 7:36 ` Eli Zaretskii [this message]
2013-04-20 14:34 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=838v4d1wmg.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=14180-done@debbugs.gnu.org \
--cc=erikcharlebois@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.