From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#15365: 24.3.50; Segfault when calling vc-git-log-edit-toggle-amend Date: Sat, 14 Sep 2013 11:02:22 +0300 Message-ID: <838uyzhlv5.fsf@gnu.org> References: <8761u5rl5c.fsf@yandex.ru> <83zjrghnca.fsf@gnu.org> <5233B818.5050705@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1379145795 10741 80.91.229.3 (14 Sep 2013 08:03:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 14 Sep 2013 08:03:15 +0000 (UTC) Cc: 15365@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 14 10:03:17 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VKkp2-0006JM-Dl for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Sep 2013 10:03:16 +0200 Original-Received: from localhost ([::1]:52281 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKkp1-0008Jc-Vp for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Sep 2013 04:03:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33230) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKkou-0008GX-9a for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2013 04:03:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VKkoo-00076Z-UR for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2013 04:03:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55581) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKkoo-00076A-RG for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2013 04:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VKkon-0004DA-Ub for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2013 04:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Sep 2013 08:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15365 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 15365-submit@debbugs.gnu.org id=B15365.137914576416158 (code B ref 15365); Sat, 14 Sep 2013 08:03:01 +0000 Original-Received: (at 15365) by debbugs.gnu.org; 14 Sep 2013 08:02:44 +0000 Original-Received: from localhost ([127.0.0.1]:35641 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VKkoV-0004CX-O8 for submit@debbugs.gnu.org; Sat, 14 Sep 2013 04:02:44 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:55155) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VKkoQ-0004CH-Uy for 15365@debbugs.gnu.org; Sat, 14 Sep 2013 04:02:40 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MT300900VDEWF00@a-mtaout20.012.net.il> for 15365@debbugs.gnu.org; Sat, 14 Sep 2013 11:02:32 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MT30095YVO8QS40@a-mtaout20.012.net.il>; Sat, 14 Sep 2013 11:02:32 +0300 (IDT) In-reply-to: <5233B818.5050705@yandex.ru> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:78383 Archived-At: > Date: Sat, 14 Sep 2013 04:12:56 +0300 > From: Dmitry Gutov > CC: 15365@debbugs.gnu.org > > On 13.09.2013 16:18, Eli Zaretskii wrote: > > Too bad this requires to commit to a git repo. > > Would your reply have been the same if it were any other VCS, save Bazaar? If you can reproduce this with bzr (I tried, but couldn't), please show the recipe. I have a number of local bzr repositories, and can create new ones at will, so I can use them for testing. For any other VCS, I have only remote repositories on my machine, and I don't dare to run such tests for a remote repo. If you can set up some scratch git repo for me at some URL, I will try using that to work on this bug. And yes, I try to stay away of git, and only use a handful of commands with it. There are already people here whose refusal to use bzr is silently tolerated, so I don't see why my desire not to touch git any more than I have to should be met with a different reaction. > > So the values of PT, Z, and Z_BYTE are important. > > (gdb) p PT > $16 = 78 > (gdb) p Z > $17 = 17704 > (gdb) p Z_BYTE > $18 = 17704 I see nothing wrong here. > > (gdb) pmtxrows current_matrix > > Here you go: > > (gdb) pmtxrows current_matrix > 0: edges=(1,77),enb=0,r2l=0,cont=0,trunc=(0,0),at_zv=0 > 1: edges=(77,78),enb=0,r2l=0,cont=0,trunc=(0,0),at_zv=0 > 2: edges=(78,79),enb=0,r2l=0,cont=0,trunc=(0,0),at_zv=0 > 3: edges=(79,124),enb=0,r2l=0,cont=0,trunc=(0,0),at_zv=0 > 4: edges=(124,171),enb=0,r2l=0,cont=0,trunc=(0,0),at_zv=0 > 5: edges=(171,193),enb=0,r2l=0,cont=0,trunc=(0,0),at_zv=0 Thanks, this was "the missing link". Please try running with the following change for a while, and see if it avoids the aborts, and does not produce any other redisplay problems: === modified file 'src/xdisp.c' --- src/xdisp.c 2013-09-13 15:03:51 +0000 +++ src/xdisp.c 2013-09-14 07:59:19 +0000 @@ -17283,8 +17283,6 @@ try_window_id (struct window *w) row = row_containing_pos (w, PT, r0, NULL, 0); if (row) set_cursor_from_row (w, row, current_matrix, 0, 0, 0, 0); - else - emacs_abort (); return 1; } } @@ -17325,8 +17323,6 @@ try_window_id (struct window *w) row = row_containing_pos (w, PT, r0, NULL, 0); if (row) set_cursor_from_row (w, row, current_matrix, 0, 0, 0, 0); - else - emacs_abort (); return 2; } }