From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 15365@debbugs.gnu.org
Subject: bug#15365: 24.3.50; Segfault when calling vc-git-log-edit-toggle-amend
Date: Sat, 14 Sep 2013 11:02:22 +0300 [thread overview]
Message-ID: <838uyzhlv5.fsf@gnu.org> (raw)
In-Reply-To: <5233B818.5050705@yandex.ru>
> Date: Sat, 14 Sep 2013 04:12:56 +0300
> From: Dmitry Gutov <dgutov@yandex.ru>
> CC: 15365@debbugs.gnu.org
>
> On 13.09.2013 16:18, Eli Zaretskii wrote:
> > Too bad this requires to commit to a git repo.
>
> Would your reply have been the same if it were any other VCS, save Bazaar?
If you can reproduce this with bzr (I tried, but couldn't), please
show the recipe. I have a number of local bzr repositories, and can
create new ones at will, so I can use them for testing. For any other
VCS, I have only remote repositories on my machine, and I don't dare
to run such tests for a remote repo. If you can set up some scratch
git repo for me at some URL, I will try using that to work on this
bug.
And yes, I try to stay away of git, and only use a handful of commands
with it. There are already people here whose refusal to use bzr is
silently tolerated, so I don't see why my desire not to touch git any
more than I have to should be met with a different reaction.
> > So the values of PT, Z, and Z_BYTE are important.
>
> (gdb) p PT
> $16 = 78
> (gdb) p Z
> $17 = 17704
> (gdb) p Z_BYTE
> $18 = 17704
I see nothing wrong here.
> > (gdb) pmtxrows current_matrix
>
> Here you go:
>
> (gdb) pmtxrows current_matrix
> 0: edges=(1,77),enb=0,r2l=0,cont=0,trunc=(0,0),at_zv=0
> 1: edges=(77,78),enb=0,r2l=0,cont=0,trunc=(0,0),at_zv=0
> 2: edges=(78,79),enb=0,r2l=0,cont=0,trunc=(0,0),at_zv=0
> 3: edges=(79,124),enb=0,r2l=0,cont=0,trunc=(0,0),at_zv=0
> 4: edges=(124,171),enb=0,r2l=0,cont=0,trunc=(0,0),at_zv=0
> 5: edges=(171,193),enb=0,r2l=0,cont=0,trunc=(0,0),at_zv=0
Thanks, this was "the missing link". Please try running with the
following change for a while, and see if it avoids the aborts, and
does not produce any other redisplay problems:
=== modified file 'src/xdisp.c'
--- src/xdisp.c 2013-09-13 15:03:51 +0000
+++ src/xdisp.c 2013-09-14 07:59:19 +0000
@@ -17283,8 +17283,6 @@ try_window_id (struct window *w)
row = row_containing_pos (w, PT, r0, NULL, 0);
if (row)
set_cursor_from_row (w, row, current_matrix, 0, 0, 0, 0);
- else
- emacs_abort ();
return 1;
}
}
@@ -17325,8 +17323,6 @@ try_window_id (struct window *w)
row = row_containing_pos (w, PT, r0, NULL, 0);
if (row)
set_cursor_from_row (w, row, current_matrix, 0, 0, 0, 0);
- else
- emacs_abort ();
return 2;
}
}
next prev parent reply other threads:[~2013-09-14 8:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-13 11:55 bug#15365: 24.3.50; Segfault when calling vc-git-log-edit-toggle-amend Dmitry Gutov
2013-09-13 13:18 ` Eli Zaretskii
2013-09-14 1:12 ` Dmitry Gutov
2013-09-14 8:02 ` Eli Zaretskii [this message]
2013-09-14 8:34 ` martin rudalics
2013-09-14 8:59 ` Eli Zaretskii
2013-09-14 9:47 ` martin rudalics
2013-09-14 10:16 ` Eli Zaretskii
2013-09-14 13:08 ` Dmitry Gutov
2013-09-14 13:45 ` Eli Zaretskii
2013-09-15 3:01 ` Dmitry Gutov
2013-09-15 6:20 ` Eli Zaretskii
2013-09-15 14:53 ` Dmitry Gutov
2013-09-14 13:05 ` Dmitry Gutov
2013-09-14 13:29 ` Eli Zaretskii
2013-09-19 8:23 ` Eli Zaretskii
2013-09-22 5:00 ` Dmitry Gutov
2013-09-22 7:14 ` Eli Zaretskii
2013-09-14 14:37 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=838uyzhlv5.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=15365@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.