bug#16636: 24.3.50; REGRESSION: y/n file dialog is only flashed; input is not read

[Eli Zaretskii <eliz@gnu.org>]

> Date: Mon, 3 Feb 2014 20:07:26 -0800 (PST)
> From: Drew Adams <drew.adams@oracle.com>
> 
> emacs -Q
> 
> Eval this after bring up Dired:
> 
> (defun diredp-mouse-find-file-other-frame (event)
>   (interactive "e")
>   (let ((pop-up-frames  t)) (dired-mouse-find-file-other-window event)))
> 
> (define-key dired-mode-map [M-mouse-2] 'diredp-mouse-find-file-other-frame)
> 
> In another Emacs session, modify one of the files listed in the Dired
> buffer.  Then click M-mouse-2 on it in the Dired buffer.
> 
> In my own setup I at least see a brief flash of a message.  I see
> nothing at all happen with emacs -Q.

You should hear the "ding" that is sounded when you type C-g or
dismiss a menu.  (And the file in question should have been already
visited inside Emacs before the "in another Emacs session" step,
otherwise Emacs has no need to display any dialogs.)

> I look in *Messages* but nothing is recorded there ("normal").

You should see "Quit" there, which is a sign that none of the possible
selections were chosen, i.e. the dialog was dismissed without making a
selection.

>  There should have been a file dialog displayed, and it should have
> waited for me to click y or n to dismiss it.
> 
> Do `M-x debug-on-entry diredp-mouse-find-file-other-frame', then repeat:
> click `M-mouse-2' on the same (modified) file.  Walk through the
> debugger and you will see the file dialog displayed as it should be

Displayed, yes.  But not "as it should be": the appearance is entirely
different, as Emacs tried to emulate a dialog box with a menu.  But
for a "simple dialog" such as yes/no, Emacs should have displayed a
MessageBox instead.

Sorry, this was my bad: some code which supported this use case was
inadvertently deleted when the TTY menus were implemented.

Now fixed in trunk revision 116260.