From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Unused/obsolete `last-code-conversion-error'? Date: Wed, 27 Aug 2014 21:22:03 +0300 Message-ID: <838um9kd2s.fsf@gnu.org> References: <53FDD86F.9060807@yandex.ru> <83sikij85u.fsf@gnu.org> <53FE059F.1020703@yandex.ru> <83d2blkh52.fsf@gnu.org> <53FE138B.8090106@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1409163736 27246 80.91.229.3 (27 Aug 2014 18:22:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 27 Aug 2014 18:22:16 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Antipov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 27 20:22:08 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XMhrD-0004iG-WD for ged-emacs-devel@m.gmane.org; Wed, 27 Aug 2014 20:22:08 +0200 Original-Received: from localhost ([::1]:32831 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMhrD-00077X-II for ged-emacs-devel@m.gmane.org; Wed, 27 Aug 2014 14:22:07 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42984) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMhr5-00076x-Vw for emacs-devel@gnu.org; Wed, 27 Aug 2014 14:22:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XMhqy-000161-OP for emacs-devel@gnu.org; Wed, 27 Aug 2014 14:21:59 -0400 Original-Received: from mtaout21.012.net.il ([80.179.55.169]:45787) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMhqy-00015m-Fs for emacs-devel@gnu.org; Wed, 27 Aug 2014 14:21:52 -0400 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0NAZ00J009DHAK00@a-mtaout21.012.net.il> for emacs-devel@gnu.org; Wed, 27 Aug 2014 21:21:50 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NAZ00JHR9OE6O90@a-mtaout21.012.net.il>; Wed, 27 Aug 2014 21:21:50 +0300 (IDT) In-reply-to: <53FE138B.8090106@yandex.ru> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:173857 Archived-At: > Date: Wed, 27 Aug 2014 21:21:15 +0400 > From: Dmitry Antipov > CC: emacs-devel@gnu.org > > On 08/27/2014 08:54 PM, Eli Zaretskii wrote: > > > But your change still assigns values to variables, so I see no real > > difference. > > ? This change completely eliminates Vlast_code_conversion_error > and all assignments to it Exactly. Instead, you assign values to internal struct members not exposed to Lisp. Sounds like a net loss to me. > plus related Qinsufficient_source, Qinvalid_source and Qinterrupted. So you saved 3 slots in obarray, why is that important? > Although we still need coding->result, we don't need to expose > relevant information to Lisp. This is Emacs, not some OO language. Maximum encapsulation is not a merit around here. IMO, this change is pointless, it removes features for no gain. It should not be done.