From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: Unused/obsolete `last-code-conversion-error'?
Date: Wed, 27 Aug 2014 21:22:03 +0300 [thread overview]
Message-ID: <838um9kd2s.fsf@gnu.org> (raw)
In-Reply-To: <53FE138B.8090106@yandex.ru>
> Date: Wed, 27 Aug 2014 21:21:15 +0400
> From: Dmitry Antipov <dmantipov@yandex.ru>
> CC: emacs-devel@gnu.org
>
> On 08/27/2014 08:54 PM, Eli Zaretskii wrote:
>
> > But your change still assigns values to variables, so I see no real
> > difference.
>
> ? This change completely eliminates Vlast_code_conversion_error
> and all assignments to it
Exactly. Instead, you assign values to internal struct members not
exposed to Lisp. Sounds like a net loss to me.
> plus related Qinsufficient_source, Qinvalid_source and Qinterrupted.
So you saved 3 slots in obarray, why is that important?
> Although we still need coding->result, we don't need to expose
> relevant information to Lisp.
This is Emacs, not some OO language. Maximum encapsulation is not a
merit around here.
IMO, this change is pointless, it removes features for no gain. It
should not be done.
prev parent reply other threads:[~2014-08-27 18:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-27 13:09 Unused/obsolete `last-code-conversion-error'? Dmitry Antipov
2014-08-27 14:53 ` Eli Zaretskii
2014-08-27 16:21 ` Dmitry Antipov
2014-08-27 16:54 ` Eli Zaretskii
2014-08-27 17:21 ` Dmitry Antipov
2014-08-27 18:22 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=838um9kd2s.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=dmantipov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.