From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin Date: Fri, 20 Feb 2015 17:10:45 +0200 Message-ID: <838ufslitm.fsf@gnu.org> References: <821tlkhq2v.fsf@gmail.com> <83mw48lwvx.fsf@gnu.org> <82wq3cga1n.fsf@gmail.com> <83ioewlv1v.fsf@gnu.org> <82sie0fz1q.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1424445088 16081 80.91.229.3 (20 Feb 2015 15:11:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 20 Feb 2015 15:11:28 +0000 (UTC) Cc: 19909@debbugs.gnu.org To: Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 20 16:11:15 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YOpEY-00008j-5u for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Feb 2015 16:11:14 +0100 Original-Received: from localhost ([::1]:60911 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOpEW-0007RA-Vu for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Feb 2015 10:11:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59904) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOpES-0007QS-Fv for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 10:11:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOpEN-0006CP-7j for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 10:11:08 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58379) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOpEN-0006CL-4N for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 10:11:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YOpEM-00048r-JK for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 10:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Feb 2015 15:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.142444504315894 (code B ref -1); Fri, 20 Feb 2015 15:11:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 20 Feb 2015 15:10:43 +0000 Original-Received: from localhost ([127.0.0.1]:49619 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOpE1-00048G-F0 for submit@debbugs.gnu.org; Fri, 20 Feb 2015 10:10:41 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:58118) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOpDy-000486-KL for submit@debbugs.gnu.org; Fri, 20 Feb 2015 10:10:39 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOpDx-000649-BB for submit@debbugs.gnu.org; Fri, 20 Feb 2015 10:10:38 -0500 Original-Received: from lists.gnu.org ([208.118.235.17]:47967) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOpDx-000645-6n for submit@debbugs.gnu.org; Fri, 20 Feb 2015 10:10:37 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59840) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOpDw-0007Pw-Dl for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 10:10:37 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOpDq-00063h-QW for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 10:10:36 -0500 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:49659) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOpDq-00063b-DL for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 10:10:30 -0500 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NK200A00SMDKN00@a-mtaout23.012.net.il> for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 17:10:29 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NK200AGXSTG7ED0@a-mtaout23.012.net.il>; Fri, 20 Feb 2015 17:10:29 +0200 (IST) In-reply-to: <82sie0fz1q.fsf@gmail.com> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:99645 Archived-At: > From: Robert Pluim > Date: Fri, 20 Feb 2015 15:16:49 +0100 > > > According to the comment in w32notify.c, w32.h is included only for > > w32_strerror. Could you try commenting out the w32.h inclusion, and > > instead copy the w32_strerror prototype into w32notify.c? Does Emacs > > compile then as part of the Cygwin-w32 build, and do file > > notifications work? (I don't have Cygwin installed to try that, > > sorry.) > > > > No, that doesn't compile. w32notify.c needs (at least) > w32_unicode_filenames, filename_to_utf16(), filename_to_ansi() and > w32_valid_pointer_p() from w32.c. Right. But those problems are quite simple to solve. Ken, would you like to try to solve them? I could suggest a patch, but it would be 100% untested. > I don't think adding w32.c into the build on cygwin is going to work. Because of the above, or because of something else?