From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: xref backends for elisp-related modes Was: Re: Bad moves with xref-find-definitions Date: Sun, 26 Apr 2015 17:51:18 +0300 Message-ID: <838udfx7rt.fsf@gnu.org> References: <87h9s6c27z.fsf@gmail.com> <87zj5wnlyt.fsf@gmail.com> <553C285B.4070400@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE X-Trace: ger.gmane.org 1430059944 30966 80.91.229.3 (26 Apr 2015 14:52:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 26 Apr 2015 14:52:24 +0000 (UTC) Cc: spinuvit@gmail.com, emacs-devel@gnu.org, monnier@IRO.UMontreal.CA, dgutov@yandex.ru To: joaotavora@gmail.com (=?utf-8?B?Sm/Do28gVMOhdm9yYQ==?=) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 26 16:52:15 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YmNup-0004CY-8n for ged-emacs-devel@m.gmane.org; Sun, 26 Apr 2015 16:52:15 +0200 Original-Received: from localhost ([::1]:51034 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YmNuo-0007Gs-4f for ged-emacs-devel@m.gmane.org; Sun, 26 Apr 2015 10:52:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37477) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YmNua-0007Ea-0g for emacs-devel@gnu.org; Sun, 26 Apr 2015 10:52:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YmNuW-00031w-QO for emacs-devel@gnu.org; Sun, 26 Apr 2015 10:51:59 -0400 Original-Received: from mtaout26.012.net.il ([80.179.55.182]:37259) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YmNuW-00031m-IE for emacs-devel@gnu.org; Sun, 26 Apr 2015 10:51:56 -0400 Original-Received: from conversion-daemon.mtaout26.012.net.il by mtaout26.012.net.il (HyperSendmail v2007.08) id <0NNF00L0057HJV00@mtaout26.012.net.il> for emacs-devel@gnu.org; Sun, 26 Apr 2015 17:53:06 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout26.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NNF00JWS5CI4720@mtaout26.012.net.il>; Sun, 26 Apr 2015 17:53:06 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:185910 Archived-At: > From: joaotavora@gmail.com (Jo=C3=A3o T=C3=A1vora) > Date: Sun, 26 Apr 2015 12:51:00 +0100 > Cc: Vitalie Spinu , > =09Stefan Monnier , emacs-devel@gnu.org >=20 > >> The patch attached does this to a certain degree, but takes some= care to > >> not do this is the major mode's definitions, since in theory the= se modes > >> could be used for something other than emacs-lisp. > > > > Makes sense. >=20 > It does, I know, but it would be a lot simpler, especially for func= tions > spawning *Help* buffers, to just assume we're in an elisp-related > context. Beware: quite a few commands pop up *Help* buffers whose contents hav= e nothing to do with Lisp. Some examples: . C-u C-x =3D . C-h C-\ . M-x describe-current-coding-system RET etc. > Anyway, this problem goes away if we take the simpler approach of j= ust > setting it in the major-mode function. It makes the resulting patch= a > lot simpler. I don't think it's right to always setup an ELisp xref backend in Hel= p mode, for the above reasons.