From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 5022e27: ; Do not overwrite preexisting contents of unread-command-events Date: Sat, 08 Aug 2015 12:11:30 +0300 Message-ID: <838u9mqh4t.fsf@gnu.org> References: <20150804124300.13374.78396@vcs.savannah.gnu.org> <2qy4hr840o.fsf@fencepost.gnu.org> <87r3nj3vbw.fsf@fencepost.gnu.org> <87k2t6i3hu.fsf@fencepost.gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1439025113 4011 80.91.229.3 (8 Aug 2015 09:11:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 8 Aug 2015 09:11:53 +0000 (UTC) Cc: rgm@gnu.org, emacs-devel@gnu.org To: David Kastrup Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Aug 08 11:11:42 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZO0AI-0007Jk-0L for ged-emacs-devel@m.gmane.org; Sat, 08 Aug 2015 11:11:42 +0200 Original-Received: from localhost ([::1]:52347 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZO0AH-0007mp-8F for ged-emacs-devel@m.gmane.org; Sat, 08 Aug 2015 05:11:41 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42862) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZO0AD-0007mf-Hx for emacs-devel@gnu.org; Sat, 08 Aug 2015 05:11:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZO0AC-0003mZ-Nj for emacs-devel@gnu.org; Sat, 08 Aug 2015 05:11:37 -0400 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:50716) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZO0A8-0003km-Ma; Sat, 08 Aug 2015 05:11:32 -0400 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NSR00I00AOMHD00@a-mtaout23.012.net.il>; Sat, 08 Aug 2015 12:11:31 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NSR00IILAV6HF00@a-mtaout23.012.net.il>; Sat, 08 Aug 2015 12:11:31 +0300 (IDT) In-reply-to: <87k2t6i3hu.fsf@fencepost.gnu.org> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.175 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:188601 Archived-At: > From: David Kastrup > Date: Sat, 08 Aug 2015 10:33:17 +0200 > Cc: emacs-devel@gnu.org > > > What do you propose I do now? > > That question was not rhetorical. It's unclear to me what exactly were you asking. If the question is how to fix that single ChangeLog entry, then the answer is: wait for the update to ChangeLog.2 to be committed (happens once a week, I think), and then manually correct (add in your case) the problematic entry, and commit the result. If you are asking about future log entries, then here's what I do: I keep a local ChangeLog file, which is unversioned. I use the normal "C-x 4 a" command to write a ChangeLog entry, and then I copy it to the log message when I commit the changeset. If the question is how to format the log entry for the particular changeset you committed in 5022e27dac4c13651941e425dbec5b3a2cecdae4, then after looking through it I see no problem to just mention every function where you made the changes. It sounds like most of them replace setq with a push, or do similar minor changes, which is fine to mention in the log entry. HTH