all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: David Kastrup <dak@gnu.org>
Cc: rgm@gnu.org, emacs-devel@gnu.org
Subject: Re: master 5022e27: ; Do not overwrite preexisting contents of unread-command-events
Date: Sat, 08 Aug 2015 12:11:30 +0300	[thread overview]
Message-ID: <838u9mqh4t.fsf@gnu.org> (raw)
In-Reply-To: <87k2t6i3hu.fsf@fencepost.gnu.org>

> From: David Kastrup <dak@gnu.org>
> Date: Sat, 08 Aug 2015 10:33:17 +0200
> Cc: emacs-devel@gnu.org
> 
> > What do you propose I do now?
> 
> That question was not rhetorical.

It's unclear to me what exactly were you asking.  If the question is
how to fix that single ChangeLog entry, then the answer is: wait for
the update to ChangeLog.2 to be committed (happens once a week, I
think), and then manually correct (add in your case) the problematic
entry, and commit the result.

If you are asking about future log entries, then here's what I do: I
keep a local ChangeLog file, which is unversioned.  I use the normal
"C-x 4 a" command to write a ChangeLog entry, and then I copy it to
the log message when I commit the changeset.

If the question is how to format the log entry for the particular
changeset you committed in 5022e27dac4c13651941e425dbec5b3a2cecdae4,
then after looking through it I see no problem to just mention every
function where you made the changes.  It sounds like most of them
replace setq with a push, or do similar minor changes, which is fine
to mention in the log entry.

HTH



  reply	other threads:[~2015-08-08  9:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20150804124300.13374.78396@vcs.savannah.gnu.org>
     [not found] ` <E1ZMbYa-0003UO-69@vcs.savannah.gnu.org>
2015-08-04 15:30   ` master 5022e27: ; Do not overwrite preexisting contents of unread-command-events Glenn Morris
2015-08-04 15:52     ` David Kastrup
2015-08-08  8:33       ` David Kastrup
2015-08-08  9:11         ` Eli Zaretskii [this message]
2015-08-08  9:38           ` David Kastrup
2015-08-08 10:18             ` Eli Zaretskii
2015-08-08 14:17         ` Stefan Monnier
2015-08-08 15:04           ` David Kastrup
2015-08-08 16:08             ` David Kastrup

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=838u9mqh4t.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=dak@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.