From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#21824: 25.0.50; overlay modification-hooks called with wrong buffer Date: Sat, 07 Nov 2015 10:28:32 +0200 Message-ID: <838u6aqklr.fsf@gnu.org> References: <83611hvl0w.fsf@gnu.org> <8337wktols.fsf@gnu.org> <83twozqhhe.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1446885028 18699 80.91.229.3 (7 Nov 2015 08:30:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 7 Nov 2015 08:30:28 +0000 (UTC) Cc: 21824@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 07 09:30:17 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zuyt7-0007Gm-01 for geb-bug-gnu-emacs@m.gmane.org; Sat, 07 Nov 2015 09:30:17 +0100 Original-Received: from localhost ([::1]:42548 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zuyt6-0001vy-Dc for geb-bug-gnu-emacs@m.gmane.org; Sat, 07 Nov 2015 03:30:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55485) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zuyt3-0001vr-ON for bug-gnu-emacs@gnu.org; Sat, 07 Nov 2015 03:30:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zuyt0-00071x-D2 for bug-gnu-emacs@gnu.org; Sat, 07 Nov 2015 03:30:13 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37427) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zuyt0-00071t-A3 for bug-gnu-emacs@gnu.org; Sat, 07 Nov 2015 03:30:10 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Zuysz-0001Ay-2g for bug-gnu-emacs@gnu.org; Sat, 07 Nov 2015 03:30:09 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Nov 2015 08:30:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21824 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21824-submit@debbugs.gnu.org id=B21824.14468849434328 (code B ref 21824); Sat, 07 Nov 2015 08:30:06 +0000 Original-Received: (at 21824) by debbugs.gnu.org; 7 Nov 2015 08:29:03 +0000 Original-Received: from localhost ([127.0.0.1]:56368 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zuyru-00017k-FO for submit@debbugs.gnu.org; Sat, 07 Nov 2015 03:29:02 -0500 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:47630) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZuyrZ-000170-Mo for 21824@debbugs.gnu.org; Sat, 07 Nov 2015 03:29:01 -0500 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NXF00600R7VFT00@a-mtaout23.012.net.il> for 21824@debbugs.gnu.org; Sat, 07 Nov 2015 10:28:39 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NXF0065ARJRDD40@a-mtaout23.012.net.il>; Sat, 07 Nov 2015 10:28:39 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:108511 Archived-At: > Date: Fri, 6 Nov 2015 21:24:50 -0500 > From: Noam Postavsky > Cc: 21824-done@debbugs.gnu.org > > On Fri, Nov 6, 2015 at 10:23 AM, Eli Zaretskii wrote: > > > > Please see if the original bug is solved by the latest master. > > Yes, it's fixed. Thanks for testing. > > Btw, any idea how come overlays wound up in *Messages* in the original > > scenario? > > global-highlight-parentheses-mode puts overlays in every buffer. Does it really mean to do that in *Messages*? If not, perhaps we should suggest to the developers of highlight-parentheses to exempt *Messages* from that, as that buffer is pretty specialized anyway. In particular, due to the way the message logging in *Messages* is implemented, the overlay modification hooks will only ever be called in that buffer with AFTER non-nil, and even that will only happen when Emacs decides to delete some text from *Messages*; inserting a new message there will never call the overlay modification hooks. > > Actually, would you like converting your test case into a test, and > > post a patch to the test suite to that effect? TIA. > > Something like this? I'm not sure where to put it. Yes, this looks good to me. How about creating a new file buffer-tests.el (the offending code is in buffer.c)? Thanks.