all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 14100-done@debbugs.gnu.org
Subject: bug#14100: 24.3.50; emacs_backtrace.txt
Date: Tue, 29 Dec 2015 19:42:27 +0200	[thread overview]
Message-ID: <838u4ddud8.fsf@gnu.org> (raw)
In-Reply-To: <87oad9lddn.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue,  29 Dec 2015 12:09:56 +0100)

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: Drew Adams <drew.adams@oracle.com>,  14100@debbugs.gnu.org
> Date: Tue, 29 Dec 2015 12:09:56 +0100
> 
> > The abort is here (in get_local_map):
> >
> >   /* Perhaps we should just change `position' to the limit.  */
> >   if (position > BUF_ZV (buffer) || position < BUF_BEGV (buffer))
> >     emacs_abort ();
> >
> > The caller, Fcurrent_active_maps, checks a different condition before
> > the call:
> >
> > 	      pos = POSN_BUFFER_POSN (position);
> > 	      if (INTEGERP (pos)
> > 		  && XINT (pos) >= BEG && XINT (pos) <= Z)
> > 		{
> > 		  local_map = get_local_map (XINT (pos),
> > 					     current_buffer, Qlocal_map);
> >
> > So perhaps the bug is in the caller: it should test BEGV and ZV
> > instead of BEG and Z.
> 
> Was there anything to be done here?  It sounds like it, but then there
> were no further messages.  :-)

The call to emacs_abort is no longer in the source.  Instead, we have
this:

    position = clip_to_bounds (BUF_BEGV (buffer), position, BUF_ZV (buffer));

So I'm closing the bug, as the problem can no longer happen.





      reply	other threads:[~2015-12-29 17:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-30 22:51 bug#14100: 24.3.50; emacs_backtrace.txt Drew Adams
2013-03-31  5:55 ` Eli Zaretskii
2015-12-29 11:09   ` Lars Ingebrigtsen
2015-12-29 17:42     ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=838u4ddud8.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=14100-done@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.