From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Suspicious code in align.el
Date: Sun, 03 Jan 2016 18:40:57 +0200
Message-ID: <838u46aa5i.fsf@gnu.org>
References: <CAAdUY-K+VCjSdGxAMZ=71saUsVffNJpivc1rPhtEQ6JHk3Ovfw@mail.gmail.com>
	<m27fjrzkup.fsf@newartisans.com>
	<CAAdUY-Kbj1bgJryaTL5rTZAQ9G1JHycgTuaF3V=s-koJuEQWpw@mail.gmail.com>
Reply-To: Eli Zaretskii <eliz@gnu.org>
NNTP-Posting-Host: plane.gmane.org
X-Trace: ger.gmane.org 1451839279 2507 80.91.229.3 (3 Jan 2016 16:41:19 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Sun, 3 Jan 2016 16:41:19 +0000 (UTC)
Cc: emacs-devel@gnu.org
To: bruce.connor.am@gmail.com
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jan 03 17:41:13 2016
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([208.118.235.17])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1aFliS-0000km-E6
	for ged-emacs-devel@m.gmane.org; Sun, 03 Jan 2016 17:41:12 +0100
Original-Received: from localhost ([::1]:42166 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1aFliR-0007VX-Up
	for ged-emacs-devel@m.gmane.org; Sun, 03 Jan 2016 11:41:11 -0500
Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40122)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1aFliG-0007VA-3N
	for emacs-devel@gnu.org; Sun, 03 Jan 2016 11:41:00 -0500
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1aFliC-0001fH-Um
	for emacs-devel@gnu.org; Sun, 03 Jan 2016 11:41:00 -0500
Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44741)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1aFliC-0001fD-SE; Sun, 03 Jan 2016 11:40:56 -0500
Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2476
	helo=HOME-C4E4A596F7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1aFliC-0003m8-6z; Sun, 03 Jan 2016 11:40:56 -0500
In-reply-to: <CAAdUY-Kbj1bgJryaTL5rTZAQ9G1JHycgTuaF3V=s-koJuEQWpw@mail.gmail.com>
	(message from Artur Malabarba on Sun, 3 Jan 2016 15:54:57 +0000)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:197464
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/197464>

> Date: Sun, 3 Jan 2016 15:54:57 +0000
> From: Artur Malabarba <bruce.connor.am@gmail.com>
> 
> 2016-01-02 22:18 GMT+00:00 John Wiegley <jwiegley@gmail.com>:
> >>>>>> Artur Malabarba <bruce.connor.am@gmail.com> writes:
> >
> >> In line 890 of this file, there's a call to align-regexp that looks like
> >> this...
> >
> > Nice catch, Artur, the code at least is wrong. The 3rd argument should be
> > shifted forward to become the 5th argument.
> >
> > I wonder what fixing this will break... :)
> 
> Since it's possible this will break something else, should this "fix"
> go on master instead of the release branch?

No, emacs-25 is fine in this case.

Thanks.