From: Eli Zaretskii <eliz@gnu.org>
To: bruce.connor.am@gmail.com
Cc: emacs-devel@gnu.org
Subject: Re: Suspicious code in align.el
Date: Sun, 03 Jan 2016 18:40:57 +0200 [thread overview]
Message-ID: <838u46aa5i.fsf@gnu.org> (raw)
In-Reply-To: <CAAdUY-Kbj1bgJryaTL5rTZAQ9G1JHycgTuaF3V=s-koJuEQWpw@mail.gmail.com> (message from Artur Malabarba on Sun, 3 Jan 2016 15:54:57 +0000)
> Date: Sun, 3 Jan 2016 15:54:57 +0000
> From: Artur Malabarba <bruce.connor.am@gmail.com>
>
> 2016-01-02 22:18 GMT+00:00 John Wiegley <jwiegley@gmail.com>:
> >>>>>> Artur Malabarba <bruce.connor.am@gmail.com> writes:
> >
> >> In line 890 of this file, there's a call to align-regexp that looks like
> >> this...
> >
> > Nice catch, Artur, the code at least is wrong. The 3rd argument should be
> > shifted forward to become the 5th argument.
> >
> > I wonder what fixing this will break... :)
>
> Since it's possible this will break something else, should this "fix"
> go on master instead of the release branch?
No, emacs-25 is fine in this case.
Thanks.
next prev parent reply other threads:[~2016-01-03 16:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-01 19:47 Suspicious code in align.el Artur Malabarba
2016-01-02 22:18 ` John Wiegley
2016-01-03 15:54 ` Artur Malabarba
2016-01-03 16:40 ` Eli Zaretskii [this message]
2016-01-03 19:11 ` Artur Malabarba
2016-01-03 19:55 ` John Wiegley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=838u46aa5i.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=bruce.connor.am@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.