From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23218: 25.1.50; find-file is noisy Date: Tue, 05 Apr 2016 17:29:58 +0300 Message-ID: <838u0snn6h.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1459866687 13421 80.91.229.3 (5 Apr 2016 14:31:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 5 Apr 2016 14:31:27 +0000 (UTC) Cc: 23218@debbugs.gnu.org To: Lars Magne Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 05 16:31:16 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1anS0h-0007Ip-Ms for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Apr 2016 16:31:15 +0200 Original-Received: from localhost ([::1]:37436 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anS0h-0002qv-6y for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Apr 2016 10:31:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59976) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anS0Y-0002j9-D7 for bug-gnu-emacs@gnu.org; Tue, 05 Apr 2016 10:31:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1anS0T-00048V-Rz for bug-gnu-emacs@gnu.org; Tue, 05 Apr 2016 10:31:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55288) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anS0T-00048R-P8 for bug-gnu-emacs@gnu.org; Tue, 05 Apr 2016 10:31:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1anS0T-0003dk-KZ for bug-gnu-emacs@gnu.org; Tue, 05 Apr 2016 10:31:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Apr 2016 14:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23218 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23218-submit@debbugs.gnu.org id=B23218.145986664113964 (code B ref 23218); Tue, 05 Apr 2016 14:31:01 +0000 Original-Received: (at 23218) by debbugs.gnu.org; 5 Apr 2016 14:30:41 +0000 Original-Received: from localhost ([127.0.0.1]:52415 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1anS05-0003d6-E0 for submit@debbugs.gnu.org; Tue, 05 Apr 2016 10:30:41 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:40517) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1anS00-0003co-Gy for 23218@debbugs.gnu.org; Tue, 05 Apr 2016 10:30:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1anRzp-0003ti-Cd for 23218@debbugs.gnu.org; Tue, 05 Apr 2016 10:30:27 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49431) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anRzp-0003tW-A0; Tue, 05 Apr 2016 10:30:21 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4208 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1anRzo-0002w0-HH; Tue, 05 Apr 2016 10:30:20 -0400 In-reply-to: (message from Lars Magne Ingebrigtsen on Mon, 04 Apr 2016 21:16:10 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:116053 Archived-At: > From: Lars Magne Ingebrigtsen > Date: Mon, 04 Apr 2016 21:16:10 +0200 > > >From -Q, open "/tmp/foo.txt", put the string "quimby.gnus.org" into the > buffer, save it, and then type `C-x C-f M-n' (which is what you'd > usually do to revert the buffer). > > The following error is signalled: > > Debugger entered--Lisp error: (file-error "make client process failed" "Connection refused" :name "ffap-machine-p" :buffer nil :host "quimby.gnus.org" :service "discard" :nowait nil :tls-parameters nil) > signal(file-error ("make client process failed" "Connection refused" :name "ffap-machine-p" :buffer nil :host "quimby.gnus.org" :service "discard" :nowait nil :tls-parameters nil)) > ffap-machine-p("quimby.gnus.org") > ffap-machine-at-point() > ffap-guesser() > ffap-guess-file-name-at-point() > run-hook-with-args-until-success(ffap-guess-file-name-at-point) > read-file-name--defaults("/tmp/" nil) The patch below seems to fix the problem. (Does anyone see a reason to run hooks in this case without blocking errors?) If no one objects or comes up with a better idea, I will commit this to the emacs-25 branch in a few days. Thanks. diff --git a/lisp/ffap.el b/lisp/ffap.el index 36727b3..2ff2588 100644 --- a/lisp/ffap.el +++ b/lisp/ffap.el @@ -1966,7 +1966,7 @@ Only intended for interactive use." (defun ffap-guess-file-name-at-point () "Try to get a file name at point. This hook is intended to be put in `file-name-at-point-functions'." - (let ((guess (ffap-guesser))) + (let ((guess (ignore-errors (ffap-guesser)))) (when (stringp guess) (let ((url (ffap-url-p guess))) (or url