From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] lexical-binding mega-patch (was: Re: [Emacs-diffs] master 05dc679: Turn on lexical-binding in json.el) Date: Thu, 29 Sep 2016 18:21:41 +0300 Message-ID: <838tuaohoa.fsf@gnu.org> References: <20160810044910.10174.12870@vcs.savannah.gnu.org> <20160810044911.2B1C52201C2@vcs.savannah.gnu.org> <20160811013050.GA4775@holos.localdomain> <20160813181832.GA15753@holos.localdomain> <83mvkgcyh1.fsf@gnu.org> <20160928171720.GA13522@holos.localdomain> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1475162587 4984 195.159.176.226 (29 Sep 2016 15:23:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 29 Sep 2016 15:23:07 +0000 (UTC) Cc: jwiegley@gmail.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Mark Oteiza Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 29 17:23:04 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bpdAi-000807-T9 for ged-emacs-devel@m.gmane.org; Thu, 29 Sep 2016 17:22:53 +0200 Original-Received: from localhost ([::1]:38740 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpdAi-0004SZ-3x for ged-emacs-devel@m.gmane.org; Thu, 29 Sep 2016 11:22:52 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42239) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpd9j-0004P9-FC for emacs-devel@gnu.org; Thu, 29 Sep 2016 11:21:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bpd9e-0005Hk-Cm for emacs-devel@gnu.org; Thu, 29 Sep 2016 11:21:50 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49528) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpd9Z-0005Fx-1X; Thu, 29 Sep 2016 11:21:41 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1944 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bpd9W-0002kU-1Z; Thu, 29 Sep 2016 11:21:38 -0400 In-reply-to: <20160928171720.GA13522@holos.localdomain> (message from Mark Oteiza on Wed, 28 Sep 2016 13:17:20 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:207899 Archived-At: > Date: Wed, 28 Sep 2016 13:17:20 -0400 > From: Mark Oteiza > Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org, jwiegley@gmail.com > > > IMO, we should have tests for each one of them before we do this. > > > > Thanks. > > Did the above in cbb2e84518 for files that already had tests written. > Tests passed. Thank you.