all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Peromsik\, Aaron" <peromsik@ptc.com>
Cc: 23709@debbugs.gnu.org
Subject: bug#23709: 24.5; inhibit-eol-conversion breaks archive-7z-summarize
Date: Fri, 07 Apr 2017 10:05:18 +0300	[thread overview]
Message-ID: <838tncofyp.fsf@gnu.org> (raw)
In-Reply-To: <DM5PR1701MB18350BA5FC7729E1D1919F51C60D0@DM5PR1701MB1835.namprd17.prod.outlook.com> (peromsik@ptc.com)

> From: "Peromsik, Aaron" <peromsik@ptc.com>
> CC: "rgm@gnu.org" <rgm@gnu.org>, "23709@debbugs.gnu.org"
> 	<23709@debbugs.gnu.org>
> Date: Thu, 6 Apr 2017 21:58:01 +0000
> 
> > Emacs on Windows doesn't save files with Windows
> > line endings, unless they had Windows line endings before you visited
> > them, and in the latter case setting inhibit-eol-conversion will not
> > help you in any way.
> 
> Not quite true. It does help me in that I can see the Windows line endings and manually remove them. 

If you want to remove them, just saving the file after typing "C-x RET
f unix RET" is a more efficient way than removing the CR characters by
hand.  (You can make the combination of the above with "C-x C-s" a
function bound to a key, so invoking it will be a snap.)  The
indication in the mode line clearly shows that the file has Windows
EOL format, so you know when to apply that.

> > But my impression was
> > that we will now have to bind it almost everywhere, in which case
> > making it not an option is a better way, IMO.
> 
> As I said, I have been happily using this option for years.

I was referring to what Glenn proposed as a remedy.

Anyway, I suggest to review this setting, because Emacs development
didn't stall since then.  You might find that there are better
solutions for the problems you had back then, and some problems might
not exist at all.

> archive-7z-summarize was the first thing I noticed
> not working because of it-- if you don't count failure to remove ^M's on paste, which I am used to by now.
> Since I filed this bug report I have been happily continuing along my way with a let binding in advice for
> archive-7z-summarize. So I suspect your fears might be overblown.

I'm okay with fixing this for archive-7z-summarize by forcing the
variable to have the right value, if that solves your problem (does
it?).  But I'm opposed to inventing yet another, separate option for
reading sub-process output, as proposed by Glenn, primarily because I
don't think it will solve problems such as this one.  I'm also opposed
to introducing any other significant infrastructure for similar use
cases, because I think having inhibit-eol-conversion globally non-nil
is a thing of the past, and there are nowadays much better and less
intrusive solutions for whatever problems people had when the related
features were first introduced into Emacs 20 years ago.





  reply	other threads:[~2017-04-07  7:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-06 21:50 bug#23709: 24.5; inhibit-eol-conversion breaks archive-7z-summarize peromsik
2017-04-04 20:10 ` Glenn Morris
2017-04-05  2:29   ` Eli Zaretskii
2017-04-05 14:14     ` Peromsik, Aaron
2017-04-05 16:00       ` Eli Zaretskii
2017-04-06 21:58         ` Peromsik, Aaron
2017-04-07  7:05           ` Eli Zaretskii [this message]
2017-04-05 15:56     ` Glenn Morris
2017-04-05 16:10       ` Eli Zaretskii
2017-04-05 19:58         ` Glenn Morris
2017-04-06  2:33           ` Eli Zaretskii
2018-02-14 11:33         ` Noam Postavsky
2018-02-14 11:51           ` Andreas Schwab
2018-02-15  1:39             ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=838tncofyp.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=23709@debbugs.gnu.org \
    --cc=peromsik@ptc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.